Rename variables to a more idiomatic value

[gentlementlegen]

Some variables should be renamed to be more meaningful:

• generateOnMissingPriceLabel => requirePriceLabel
• types => targets

Related conversations:

• https://github.com/ubiquibot/conversation-rewards/pull/32#discussion_r1632623409
• https://github.com/ubiquibot/conversation-rewards/pull/32#discussion_r1632609123

[0x4007]

Perhaps it makes sense to finalize this spec after a first draft of final property names? Then we can all discuss and iterate on the property names

[gentlementlegen]

Fine by me! But I think your suggestions were quite relevant, just not part of the other pull request. It's a quick change, PR ready.

[ubiquibot[bot]]

! No price label has been set. Skipping permit generation.

[ubiquibot-v2-testing[bot]]

[ 2.106 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	2.106

Conversation Incentives

Comment	Formatting	Relevance	Reward
Perhaps it makes sense to finalize this spec after a first draft…	2.7 p: count: 27 score: 1	0.78	2.106

[ 6.418 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	2.268
Issue	Comment	1	4.15

Conversation Incentives

Comment	Formatting	Relevance	Reward
Some variables should be renamed to be more meaningful: - `gener…	2.7 p: count: 23 score: 1 code: count: 4 score: 1	0.84	2.268
Fine by me! But I think your suggestions were quite relevant, ju…	5 p: count: 25 score: 1	0.83	4.15

[gentlementlegen]

Reopened just to test if the bot skips permit generation or not.

[ubiquibot[bot]]

! No price label has been set. Skipping permit generation.

[ubiquibot-v2-testing[bot]]

[ 2.16 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	2.16

Conversation Incentives

Comment	Formatting	Relevance	Reward
Perhaps it makes sense to finalize this spec after a first draft…	2.7 p: count: 27 score: 1	0.8	2.16

[ 5.862 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	2.7
Issue	Comment	2	3.162

Conversation Incentives

Comment	Formatting	Relevance	Reward
Some variables should be renamed to be more meaningful: - `gener…	2.7 p: count: 23 score: 1 code: count: 4 score: 1	1	2.7
Fine by me! But I think your suggestions were quite relevant, ju…	5 p: count: 25 score: 1	0.33	1.65
Reopened just to test if the bot skips permit generation or not.	2.4 p: count: 12 score: 1	0.63	1.512

[gentlementlegen]

@0x4007 I think the Kernel is running on an old deployment, this issue happens because the Kernel is still invoking https://github.com/ubiquibot/conversation-rewards/tree/testing/ubiquibot-v2-testing instead of the dev branch, which also means it uses https://github.com/ubiquibot/configuration/blob/development/.github/.ubiquibot-config.yml for its config. I updated the branch and the configuration in the meantime, but I believe Kernel deployment should be up-to-date, and eventually automated if that is not already the case.

[ubiquibot[bot]]

! No price label has been set. Skipping permit generation.

[ubiquibot-v2-testing[bot]]

! No price label has been set. Skipping permit generation.