ubiquibot / conversation-rewards

0 stars 10 forks source link

Exponential Backoff Instead of Fail #4

Open 0x4007 opened 3 months ago

0x4007 commented 3 months ago

I guess my aspiration would be that we can handle situations where we fail to retrieve the data elegantly. What about an exponential back off? The GitHub action has the ability to run for six hours!

Otherwise, if that's a bad idea then yes I agree with whilefoo that it should throw and exit the process.

I'm still definitely leaning towards exponential backoff idea though, which implies that it should never be null, but instead perhaps, undefined.

This can be addressed in another task

_Originally posted by @pavlovcik in https://github.com/ubiquibot/conversation-rewards/pull/3#discussion_r1536977274_

PhantomCracker commented 2 months ago

@0x4007 is this still available? I was thinking on implementing a backoff solution, but I already see some changes there: self: GitHubIssue | null = null;

0x4007 commented 1 month ago

@gentlementlegen did you implement this in the new plugin? Never let it fail, just exponential back off!

gentlementlegen commented 1 month ago

@0x4007 Partially, but there should be fatal errors that still stop the plugin from running otherwise it would indefinitely fail isn't it?

0x4007 commented 1 month ago

This task is strictly about collecting the information that it should have access to from GitHub. Six hour hard timeout anyways.