ubiquibot / conversation-rewards

0 stars 18 forks source link

Typebox error handling and issue feedback #96

Open Keyrxng opened 3 weeks ago

Keyrxng commented 3 weeks ago

An issue exists with the usage of T.Union which should be investigated and resolved.

It would also be handy to improve user feedback on the issue as a user must head to the workflow run to get a hint at what is going on.

I'm unsure what labels to assign, you would know better @gentlementlegen

original context

tiilliir commented 1 week ago

/start

ubiquity-os[bot] commented 1 week ago
DeadlineWed, Sep 4, 8:01 PM UTC
Registered Wallet 0x58e83B330158Ba79de3caC0bC5B190F6eA000E69
Tips:
<ul>
<li>Use <code>/wallet 0x0000...0000</code> if you want to update your registered payment wallet address.</li>
<li>Be sure to open a draft pull request as soon as possible to communicate updates on your progress.</li>
<li>Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.</li>
<ul>
tiilliir commented 1 week ago

‏/wallet 0x58e83b330158ba79de3cac0bc5b190f6ea000e69

ubiquity-os[bot] commented 1 week ago

@tiilliir, this task has been idle for a while. Please provide an update.

ubiquity-os[bot] commented 4 days ago

@tiilliir, this task has been idle for a while. Please provide an update.

0x4007 commented 4 days ago

A double follow up with no update is unusual @gentlementlegen @Keyrxng can you guys investigate

Keyrxng commented 4 days ago

A double follow up with no update is unusual @gentlementlegen @Keyrxng can you guys investigate

Looks like we need to exclude events like subscribed, mentioned. Below is the last two activity events for this task in respect to the contributor.

{
  id: 14254408264,
  node_id: 'MEE_lADOLUK0B86UFNt9zwAAAANRoQJI',
  url: 'https://api.github.com/repos/ubiquibot/conversation-rewards/issues/events/14254408264',
  actor: {
    login: 'tiilliir',
    id: 180199616,
    node_id: 'U_kgDOCr2gwA',
    type: 'User',
    site_admin: false
  },
  event: 'mentioned',
  commit_id: null,
  commit_url: null,
  created_at: '2024-09-13T20:55:35Z',
  performed_via_github_app: null
} {
  id: 14254408270,
  node_id: 'SE_lADOLUK0B86UFNt9zwAAAANRoQJO',
  url: 'https://api.github.com/repos/ubiquibot/conversation-rewards/issues/events/14254408270',
  actor: {
    login: 'tiilliir',
    id: 180199616,
    node_id: 'U_kgDOCr2gwA',
    type: 'User',
    site_admin: false
  },
  event: 'subscribed',
  commit_id: null,
  commit_url: null,
  created_at: '2024-09-13T20:55:35Z',
  performed_via_github_app: null
}

Can either of you think of other events we might need to handle and I or someone can look into it further via a task?

mentioned, subscribed, unsubscribed, reactions, comment.deleted and edited too I'd say...

0x4007 commented 4 days ago

Not sure. Let's iterate until we get it right.

0x4007 commented 3 days ago

Not sure. Let's iterate until we get it right.

Actually, perhaps it makes sense to do a whitelist approach.

I think thats it for now.

ubiquity-os[bot] commented 17 hours ago

@tiilliir, this task has been idle for a while. Please provide an update.