Closed gitcoindev closed 3 months ago
Lines | Statements | Branches | Functions |
---|---|---|---|
81.02% (158/195) | 54.28% (19/35) | 76.47% (13/17) |
Tests | Skipped | Failures | Errors | Time |
---|---|---|---|---|
14 | 0 :zzz: | 0 :x: | 0 :fire: | 8.137s :stopwatch: |
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
---|---|---|---|---|---|
All files | 81.02 | 54.28 | 76.47 | 81.02 | |
src/handlers | 78.7 | 54.83 | 66.66 | 78.7 | |
generate-erc20-permit.ts | 79.06 | 44.44 | 50 | 79.06 | 19–22, 26, 47, 53, 81–83 |
generate-erc721-permit.ts | 88.46 | 75 | 80 | 88.46 | 39–40, 69–70, 105–106 |
generate-payout-permit.ts | 73.33 | 33.33 | 100 | 73.33 | 25–29 |
register-wallet.ts | 68.88 | 60 | 50 | 68.88 | 15–21, 43, 52, 61–64, 77–78 |
src/types | 100 | 100 | 100 | 100 | |
typeguards.ts | 100 | 100 | 100 | 100 | |
src/utils | 87.5 | 50 | 100 | 87.5 | |
keys.ts | 84.61 | 33.33 | 100 | 84.61 | 13–14, 18–19 |
payoutConfigByNetworkId.ts | 100 | 100 | 100 | 100 | |
tests | 100 | 100 | 100 | 100 | |
constants.ts | 100 | 100 | 100 | 100 |
Knip green, QA also done in my forked repository: https://github.com/gitcoindev/permit-generation/pull/2
I noticed some spelling errors thrown by cspell, give me a minute and I will fix them in one go.
Knip green again, spelling issues fixed, pr ready for the review.
Interestingly Knip detects i
in yml wokflow files after yarn command e.g. yarn i
as a standalone binary with name i
. I had to change it to yarn install
and the error was gone. I think we can leave the full install
for clarity and remember to use it in all GitHub workflow files.
thanks for the PR, looks great
let me review accordingly next time lol @gitcoindev
let me review accordingly next time lol @gitcoindev
Sure, I will!
Knip QA