ubiquibot / permit-generation

A standalone module to generate permits.
0 stars 6 forks source link

Fix knip issues #9

Closed gitcoindev closed 3 months ago

gitcoindev commented 3 months ago

Knip QA

github-actions[bot] commented 3 months ago
Lines Statements Branches Functions
Coverage: 81%
81.02% (158/195) 54.28% (19/35) 76.47% (13/17)

JUnit

Tests Skipped Failures Errors Time
14 0 :zzz: 0 :x: 0 :fire: 8.137s :stopwatch:
Coverage Report (81%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files81.0254.2876.4781.02 
src/handlers78.754.8366.6678.7 
   generate-erc20-permit.ts79.0644.445079.0619–22, 26, 47, 53, 81–83
   generate-erc721-permit.ts88.46758088.4639–40, 69–70, 105–106
   generate-payout-permit.ts73.3333.3310073.3325–29
   register-wallet.ts68.88605068.8815–21, 43, 52, 61–64, 77–78
src/types100100100100 
   typeguards.ts100100100100 
src/utils87.55010087.5 
   keys.ts84.6133.3310084.6113–14, 18–19
   payoutConfigByNetworkId.ts100100100100 
tests100100100100 
   constants.ts100100100100 
gitcoindev commented 3 months ago

Knip green, QA also done in my forked repository: https://github.com/gitcoindev/permit-generation/pull/2

I noticed some spelling errors thrown by cspell, give me a minute and I will fix them in one go.

gitcoindev commented 3 months ago

Knip green again, spelling issues fixed, pr ready for the review.

gitcoindev commented 3 months ago

Interestingly Knip detects i in yml wokflow files after yarn command e.g. yarn i as a standalone binary with name i. I had to change it to yarn install and the error was gone. I think we can leave the full install for clarity and remember to use it in all GitHub workflow files.

molecula451 commented 3 months ago

thanks for the PR, looks great

molecula451 commented 3 months ago

let me review accordingly next time lol @gitcoindev

gitcoindev commented 3 months ago

let me review accordingly next time lol @gitcoindev

Sure, I will!