search

ubiquibot / plugins-wishlist

0 stars 1 forks source link

command/authorize: set label access to users #11

Closed gentlementlegen closed 2 weeks ago

gentlementlegen commented 1 month ago

command/authorize: this had the worst UX but being able to set label access for users. This should also be redone to have better UX, while still allowing arbitrary label name access control.

See source code

whilefoo commented 2 weeks ago

I'm not sure I saw this command used in the real world so I'm not sure what's the intended usage. I know that assistive-pricing already has functionality to allow certain users to set certain labels. @0x4007 rfc

0x4007 commented 2 weeks ago

I'm not sure I saw this command used in the real world so I'm not sure what's the intended usage. I know that assistive-pricing already has functionality to allow certain users to set certain labels. @0x4007 rfc

If it has the capability then we can close this.

ubiquibot[bot] commented 2 weeks ago 
# Issue was not closed as completed. Skipping.
0x4007 commented 2 weeks ago

@whilefoo please identify the source code that handles this, I couldn't find it upon first glance at https://github.com/ubiquibot/assistive-pricing/tree/development/src

whilefoo commented 2 weeks ago

onLabelChangeSetPricing is triggered when a label on the issue gets added/removed, and sets the price label but also calls labelAccessPermissionsCheck which checks if the user has permission to set the label otherwise adds/removes it.

0x4007 commented 2 weeks ago

Those don't handle setting the permissions.

0x4007 commented 2 weeks ago

This also raises the question of the coupling of separate plugins capabilities. It would be broken/useless code if the project added one plugin and not the other for example.

Let us include all the logic in a single plugin instead.

whilefoo commented 2 weeks ago

Those don't handle setting the permissions.

it also handles setting the permission

ubiquibot[bot] commented 2 weeks ago 
# Issue was not closed as completed. Skipping.