Plugin starter pack - Githubissues

Keyrxng commented 1 month ago

Package all of the common and required parts needed to build a plugin and host a template repo

All common shared types
All Supabase adapters
Libs such as @ubiquity/configuration, @ubiquity/logger?, ...etc
Basic ts plugin entry w/ Context setup
Basic workflow setup
Maybe some of the most used utility/helper functions because there are a few variations of these functions across different features all doing the same thing
Strip out unused scaffolding from https://github.com/ubiquity/ts-template (cypress, esbuild etc) using that as the foundation
Include steps on how to test a plugin locally when in development

Improves DX, streamlines development and with any breaking changes to how plugins are developed they can be kept up-to date in the template's readme.

I have based my plugins so far on the structure of Assistive Pricing
Start/Stop is closer to what the template should look like but should be more broad-strokes that way developers can remove whatever pieces they don't need (i.e adapters etc)

time estimate: < 1-2 hrs

Keyrxng commented 1 month ago

https://github.com/Keyrxng/ubiquibot-plugin-template

very basic rn but gets the core stuff needed to get up and running quickly

adding specific utils etc will be easier once all of V1 has been ported/I have more exp porting/creating plugins. It started to quickly bloat so I kept it thin for now

Keyrxng commented 1 month ago

/start

Just tried to transfer my repo to the org but no joy, I'll PR it against the repo once created.

ubiquibot[bot] commented 1 month ago




Deadline Sun, May 19, 1:35 PM UTC

Registered Wallet
0xAe5D1F192013db889b1e2115A370aB133f359765

Tips:

Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

gentlementlegen commented 1 month ago

@Keyrxng Please move the work to the following repository https://github.com/ubiquibot/plugin-template

Also side note, the template should include the Worker setup as well I suppose.

gentlementlegen commented 4 weeks ago

@Keyrxng How is this coming along? Would be neat to have it for future plugins.

Keyrxng commented 4 weeks ago

@gentlementlegen I'll get on it, I was holding off because of https://github.com/ubiquibot/plugins-wishlist/issues/9 not moving along thinking that the reason is because the direction for workers wasn't completely decided on.

I also wasn't sure if I was approaching it right either, but I'll bring over what I have.

gentlementlegen commented 4 weeks ago

We have https://github.com/ubiquibot/command-query-user which was set up as a worker. I think the template should contain both setups, since they can coexist with no issue.

Keyrxng commented 4 weeks ago

@gentlementlegen can you add an empty readme to the repo so I can fork it easier please bud

GH UI not registering my git cloned empty repo even with upstream etc set right, I think GH UI is the only other way as GH desktop isn't picking up on it being a forked clone either, but did warn that I had forked an empty repo.

gentlementlegen commented 4 weeks ago

@Keyrxng Good to go

ubiquibot[bot] commented 3 weeks ago

+ Evaluating results. Please wait...

ubiquibot-v2-testing[bot] commented 3 weeks ago

[ 88.601 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	9.487
Issue	Comment	4	11.778
Review	Comment	17	67.336

Conversation Incentives

Comment	Formatting	Relevance	Reward
Package all of the common and required parts needed to build a p…	17.9 p: count: 174 score: 1 code: count: 2 score: 1 a: count: 3 score: 1	0.53	9.487
- https://github.com/Keyrxng/ubiquibot-plugin-template very basi…	18.8 ul: count: 47 score: 1 li: count: 47 score: 1	0.16	3.008
Just tried to transfer my repo to the org but no joy, I'll PR it…	4 p: count: 20 score: 1	0.15	0.6
@gentlementlegen I'll get on it, I was holding off because of ht…	9.4 p: count: 47 score: 1	0.15	1.41
@gentlementlegen can you add an empty readme to the repo so I ca…	13 p: count: 65 score: 1	0.52	6.76
Resolves https://github.com/ubiquibot/plugins-wishlist/issues/13…	0 p: count: 20 score: 1 code: count: 2 score: 1	0.56	-
I don't understand, you mean remove `name, permissions and env`?…	10 p: count: 20 score: 1 code: count: 5 score: 1	0.43	4.3
If I remove the DB type I'll have to remove most types across th…	12 p: count: 27 score: 1 code: count: 3 score: 1	0.41	4.92
It's in the readme, which is a web3 ref. I thought I removed it …	13.2 p: count: 33 score: 1	0.35	4.62
ah no probs. And that's only because it's injected into the env …	24.4 p: count: 45 score: 1 code: count: 16 score: 1	0.28	6.832
to do something nah it's just a placeholder and is called in `pl…	8 p: count: 19 score: 1 code: count: 1 score: 1	0.15	1.2
Do you mean like this, as this happens inside `plugin.ts` alread…	33.6 p: count: 68 score: 1 code: count: 16 score: 1	0.06	2.016
I think my mental model has been a little off especially when it…	16.4 p: count: 40 score: 1 code: count: 1 score: 1	0.2	3.28
removed in favour of a comment	2.4 p: count: 6 score: 1	0.22	0.528
I've added it so that it doesn't need to be added later but I wa…	14.8 p: count: 37 score: 1	0.22	3.256
my mistake didn't realize I had overlooked this	3.2 p: count: 8 score: 1	0.33	1.056
It's used in the logs in V1 but I'm sure I was having issues wit…	11.2 p: count: 26 score: 1 code: count: 2 score: 1	0.24	2.688
A few questions that I'm unsure of myself. - So private org conf…	60.4 p: count: 145 score: 1 code: count: 6 score: 1	0.37	22.348
I always forget to tag, @gentlementlegen	2.4 p: count: 6 score: 1	0.41	0.984
Do you have any more info to add to the readme or would like som…	16 p: count: 40 score: 1	0.28	4.48
@gentlementlegen requested changes made. I also removed the ref …	6 p: count: 13 score: 1 code: count: 2 score: 1	0.45	2.7
I agree and np if it's still open I'll look into it next week	5.6 p: count: 14 score: 1	0.38	2.128

[ 0 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward

Conversation Incentives

Comment	Formatting	Relevance	Reward

ubiquibot[bot] commented 3 weeks ago

[ 7.9 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	4	7.9

Conversation Incentives

Comment	Formatting	Relevance	Reward
@Keyrxng Please move the work to the following repository https...	2.9	0.56	2.9
@Keyrxng How is this coming along? Would be neat to have it for ...	1.5	0.72	1.5
We have https://github.com/ubiquibot/command-query-user which wa...	3.1	0.81	3.1
@Keyrxng Good to go...	0.4	0.625	0.4

[ 87.2 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	50.4
Issue	Comment	3	36.8

Conversation Incentives

Comment	Formatting	Relevance	Reward
Package all of the common and required parts needed to build a p...	50.4 h5: count: 1 score: "1" words: 6 a: count: 2 score: "2" words: 4 li: count: 10 score: "10" words: 151 code: count: 2 score: "2" words: 4	1	50.4
- https://github.com/Keyrxng/ubiquibot-plugin-template very b...	12 li: count: 1 score: "1" words: 7	0.57	12
@gentlementlegen I'll get on it, I was holding off because of ht...	11.6	0.745	11.6
@gentlementlegen can you add an empty readme to the repo so I ca...	13.2	0.49	13.2

Keyrxng commented 3 weeks ago

@0x4007 @gentlementlegen, shouldn't it be the case that if someone creates the issue and then also completes it then they should receive whichever reward is the highest between the task price and task creation reward + comments?

EDIT:

I think it's happened because the bot rogue unassigned me so the permit was created without an assignee on the issue

EDIT 2:

A check should probably be added to the permit generation so that it doesn't generate a permit without an assignee attached to the issue. It should either assign the author of the PR that is being closed as complete automatically or alert the person merging by tagging them in a comment or something?

EDIT 3:

I'm going to claim it as-is because I need it and in case I am wrong about the circumstance. Hoping that any difference owed (if-any) can be handled (as I know it's once nonce per issue) via direct transfer or a bump on one of my other tasks.

ubiquibot[bot] commented 3 weeks ago

@Keyrxng the deadline is at 2024-06-09T15:27:03.787Z

ubiquibot[bot] commented 3 weeks ago

+ Evaluating results. Please wait...

ubiquibot[bot] commented 3 weeks ago

[ 7.9 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	4	7.9

Conversation Incentives

Comment	Formatting	Relevance	Reward
@Keyrxng Please move the work to the following repository https...	2.9	0.58	2.9
@Keyrxng How is this coming along? Would be neat to have it for ...	1.5	0.65	1.5
We have https://github.com/ubiquibot/command-query-user which wa...	3.1	0.695	3.1
@Keyrxng Good to go...	0.4	0.2	0.4

[ 271.2 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	50.4
Issue	Task	1	150
Issue	Comment	4	70.8
Issue	Comment	4	0

Conversation Incentives

Comment	Formatting	Relevance	Reward
Package all of the common and required parts needed to build a p...	50.4 h5: count: 1 score: "1" words: 6 a: count: 2 score: "2" words: 4 li: count: 10 score: "10" words: 151 code: count: 2 score: "2" words: 4	1	50.4
- https://github.com/Keyrxng/ubiquibot-plugin-template very b...	12 li: count: 1 score: "1" words: 7	0.46	12
@gentlementlegen I'll get on it, I was holding off because of ht...	11.6	0.725	11.6
@gentlementlegen can you add an empty readme to the repo so I ca...	13.2	0.28	13.2
@0x4007 @gentlementlegen, shouldn't it be the case that if someo...	34	0.27	34
- https://github.com/Keyrxng/ubiquibot-plugin-template very b...	- li: count: 1 score: "0" words: 7	0.46	-
@gentlementlegen I'll get on it, I was holding off because of ht...	-	0.725	-
@gentlementlegen can you add an empty readme to the repo so I ca...	-	0.28	-
@0x4007 @gentlementlegen, shouldn't it be the case that if someo...	-	0.27	-

ubiquibot-v2-testing[bot] commented 3 weeks ago

[ 219.1295 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	150
Issue	Specification	1	4.3855
Issue	Comment	5	8.406
Review	Comment	17	56.338

Conversation Incentives

Comment	Formatting	Relevance	Reward
Package all of the common and required parts needed to build a p…	17.9 p: count: 174 score: 1 code: count: 2 score: 1 a: count: 3 score: 1	0.245	4.3855
- https://github.com/Keyrxng/ubiquibot-plugin-template very basi…	18.8 ul: count: 47 score: 1 li: count: 47 score: 1	0.2	3.76
Just tried to transfer my repo to the org but no joy, I'll PR it…	4 p: count: 20 score: 1	0.2	0.8
@gentlementlegen I'll get on it, I was holding off because of ht…	9.4 p: count: 47 score: 1	0.05	0.47
@gentlementlegen can you add an empty readme to the repo so I ca…	13 p: count: 65 score: 1	0.02	0.26
@0x4007 @gentlementlegen, shouldn't it be the case that if someo…	32.8 p: count: 164 score: 1	0.095	3.116
Resolves https://github.com/ubiquibot/plugins-wishlist/issues/13…	0 p: count: 20 score: 1 code: count: 2 score: 1	0.365	-
I don't understand, you mean remove `name, permissions and env`?…	10 p: count: 20 score: 1 code: count: 5 score: 1	0.59	5.9
If I remove the DB type I'll have to remove most types across th…	12 p: count: 27 score: 1 code: count: 3 score: 1	0.42	5.04
It's in the readme, which is a web3 ref. I thought I removed it …	13.2 p: count: 33 score: 1	0.255	3.366
ah no probs. And that's only because it's injected into the env …	24.4 p: count: 45 score: 1 code: count: 16 score: 1	0.15	3.66
to do something nah it's just a placeholder and is called in `pl…	8 p: count: 19 score: 1 code: count: 1 score: 1	0.315	2.52
Do you mean like this, as this happens inside `plugin.ts` alread…	33.6 p: count: 68 score: 1 code: count: 16 score: 1	0.29	9.744
I think my mental model has been a little off especially when it…	16.4 p: count: 40 score: 1 code: count: 1 score: 1	0.255	4.182
removed in favour of a comment	2.4 p: count: 6 score: 1	0.19	0.456
I've added it so that it doesn't need to be added later but I wa…	14.8 p: count: 37 score: 1	0.205	3.034
my mistake didn't realize I had overlooked this	3.2 p: count: 8 score: 1	0.205	0.656
It's used in the logs in V1 but I'm sure I was having issues wit…	11.2 p: count: 26 score: 1 code: count: 2 score: 1	0.18	2.016
A few questions that I'm unsure of myself. - So private org conf…	60.4 p: count: 145 score: 1 code: count: 6 score: 1	0.12	7.248
I always forget to tag, @gentlementlegen	2.4 p: count: 6 score: 1	0.175	0.42
Do you have any more info to add to the readme or would like som…	16 p: count: 40 score: 1	0.31	4.96
@gentlementlegen requested changes made. I also removed the ref …	6 p: count: 13 score: 1 code: count: 2 score: 1	0.28	1.68
I agree and np if it's still open I'll look into it next week	5.6 p: count: 14 score: 1	0.26	1.456

[ 0 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward

Conversation Incentives

Comment	Formatting	Relevance	Reward

gentlementlegen commented 3 weeks ago

@Keyrxng Should be fixed now. The reason why you got unassigned is most likely because you were considered as inactive, but the bot does not update a user status without having any sort of activity on the task.

Keyrxng commented 3 weeks ago

[ 7.9 WXDAI ]

@gentlementlegen

[ 271.2 WXDAI ]

@Keyrxng

Hotdamn, I expected a difference of ~$80. I had to claim the permit this morning for $87 as I needed it for food (one day I'll be poverty free 🤣).

@0x4007 would you be able to manual the difference this one time and I will not do this again, I'd of been okay losing ~$80 if there was no resolve possible but not ~$190 that's brutal af.

I hear you regarding the bot ejection @gentlementlegen, it was just a thought, it could be a potential new plugin even?

gentlementlegen commented 3 weeks ago

@Keyrxng Yes, working on it: https://github.com/ubiquibot/plugins-wishlist/issues/7

Keyrxng commented 3 weeks ago

@gentlementlegen I was meaning the specific feature of re-assigning the author of the incoming merge if they are currently not assigned to the assignee and the assignee is null?

e.g. if they have been removed by wildcard/unassign previously but are the rightful PR author when the PR is finally merged. e.g. alternatively, if the assignee is not null. You resolved an issue not too long ago which jordan was assigned to, the merged PR you authored and subsequently you received the payout albeit manually processed after the merge. This new plugin could handle these scenarios and remove the need for reviewers/hunters to double check before generating the permit?

If a user has been removed by wildcard then they'll have had the XP/Karma reductions so being unassigned and then it being merged 1 or 2 weeks later (through either their own fault or due to slow review) has no negative effects.

Other than, an issue appears to be open and workable when in reality it isn't so it circumvents that a bit.

I'm just thinking QOL would be improved

EDIT:

I realise that you may already be including this logic and that is what you meant if so just ignore this 😂

gentlementlegen commented 3 weeks ago

This is a valid point, but I think this scenario is induced by the unassign logic not being accurate. If a user gets a reminder and a notification when they get unassigned, they would have reassigned themselves before the PR was opened / merged. In your case you got unassigned the same second the PR was closed which resulted in this problem. Hopefully this scenario would not be common on the v2, but I'll keep it in mind.

0x4007 commented 3 weeks ago

@Keyrxng I sent 150 for the task reward. In the future, consider reviewing the contribution breakdown before accepting to know if something is off. https://gnosisscan.io/tx/0x2d809e7abe91a4751da60483b3c95c19b398a1167872286474dee9ed0110117b

Keyrxng commented 3 weeks ago

@0x4007 thank you and I will do!

Deadline	Sun, May 19, 1:35 PM UTC
Registered Wallet	0xAe5D1F192013db889b1e2115A370aB133f359765

ubiquibot / plugins-wishlist

Plugin starter pack #13

time estimate: < 1-2 hrs

Tips:

@Keyrxng

Contributions Overview

Conversation Incentives

@gentlementlegen

Contributions Overview

Conversation Incentives

@gentlementlegen

Contributions Overview

Conversation Incentives

@Keyrxng

Contributions Overview

Conversation Incentives

@gentlementlegen

Contributions Overview

Conversation Incentives

@Keyrxng

Contributions Overview

Conversation Incentives

@Keyrxng

Contributions Overview

Conversation Incentives

@gentlementlegen

Contributions Overview

Conversation Incentives

@gentlementlegen

@Keyrxng