KYC Permits - Githubissues

ubiquibot / plugins-wishlist

0 stars 1 forks source link

KYC Permits #24

Open 0x4007 opened 1 week ago

0x4007 commented 1 week ago

Powerhouse inquired about KYC for payments.

We can fork our permit generation module and then add a KYC check.
We should use an API for a third party KYC provider.

Todo:

Research a suitable KYC provider.
Decide if we should intercept the /start command and check if they already KYC'd (seems like the best UX to warn them up front.)
Ensure that the permit is not generated if KYC did not pass.

rndquu commented 3 days ago

Decide if we should intercept the /start command and check if they already KYC'd (seems like the best UX to warn them up front.)

The /start command should be responsible solely for using github API. We could simply put the "KYC plugin" in the config chain before the /start command and throw an error in case KYC is not passed.

0x4007 commented 2 days ago

We could simply put the "KYC plugin" in the config chain before the /start command and throw an error in case KYC is not passed.

Just because a plugin throws an error doesn't mean the others should halt execution, right? However, with this scenario it makes a lot of sense.

So we can associate a "sub plugin-chain" on the webhook event name level i.e. issues_comment.created and if any of those plugins fail in the subchain then halt the rest of that chain.

@whilefoo @gentlementlegen rfc

rndquu commented 2 days ago

We could simply put the "KYC plugin" in the config chain before the /start command and throw an error in case KYC is not passed.

Just because a plugin throws an error doesn't mean the others should halt execution, right? However, with this scenario it makes a lot of sense.

@whilefoo @gentlementlegen rfc

This looks like a plugin's SDK method similar to pluginSdk.halt()