search

ubiquibot / plugins-wishlist

0 stars 1 forks source link

command/[start | stop] #9

Open gentlementlegen opened 1 month ago

gentlementlegen commented 1 month ago

A user should be able to start or stop working on a task, by typing /start or /stop within a comment under an issue.

Stop this one will be especially useful to gracefully quit a task without losing XP. if somebody is disqualified through poor/non performance, then they will get negative XP.

See code reference

jordan-ae commented 1 month ago

@gentlementlegen so this start/stop should work exactly how the v1 Bot does currently?

gentlementlegen commented 1 month ago

@jordan-ae Correct, the goal is to reimplement the same functionalities but in a cleaner manner within separate modules.

Keyrxng commented 1 month ago

/start

ubiquibot[bot] commented 1 month ago

DeadlineThu, May 16, 10:25 PM UTC
Registered Wallet 0xAe5D1F192013db889b1e2115A370aB133f359765
Tips:
Keyrxng commented 1 month ago

@gentlementlegen is there a structure yet for the XP?

Or should I cover commands for admins like:

while the default for a hunter would be the same /stop

/assign|/unassign were commands in V1 but could be bundled into this module as it's the same functionality it makes sense to have it as one module I think, what are your thoughts here?

Keyrxng commented 1 month ago

/stop

ubiquibot[bot] commented 1 month ago 
+ You have been unassigned from the task
Keyrxng commented 1 month ago

/start

ubiquibot[bot] commented 1 month ago

DeadlineFri, May 17, 3:58 PM UTC
Registered Wallet 0xAe5D1F192013db889b1e2115A370aB133f359765
Tips:
Keyrxng commented 1 month ago

Is a new repo going to be created for each plugin in the wishlist or are we to open PRs against this repo?

RFC @0x4007

0x4007 commented 1 month ago

Each plugin should be hosted on their own repositories. I imagine we will have a dedicated organization to host "official" plugins.

Keyrxng commented 1 month ago

I thought that was the plan eventually, in the meantime think you could create one for start/stop for me please mate and I'll open a draft pr with this

0x4007 commented 1 month ago

I am not with my computer so @gentlementlegen maybe you can. Anyways you can work anywhere and then open a pull later when the repo is ready.

Keyrxng commented 1 month ago

Both have been mentioned to handle XP deductions although it should only be one.

I think it makes sense for #7 to have this plugin as part of it's plugins: uses: with: config, sending a negative XP amount and "stop" once it decides to kick & penalize the hunter. By invoking this plugin, any open PR would also be closed and XP is handled by only one.

Or I can remove the notion of XP handling in this and have it be just a slash command plugin for /start and /stop not invoked by any other plugin. If #7 kicks the user and handles XP then it won't need to call into this which means a user can only use /stop while still still inside the deadline which shouldn't incur a negative XP impact anyway right?

0x4007 commented 1 month ago

Only wildcard unassign should deduct XP for inactivity. If a user gives up with /stop within the allocated timeframe it's fine. No punishment.

Keyrxng commented 1 month ago

PR ready for review once the repo is good to go.

I assume the org will just be @ubiquibot-plugins/start-stop for example? I've used that name for it temporarily

gentlementlegen commented 1 month ago

Apologies this slipped my mind. start-stop seems like a poor naming, maybe more something like assignee-manager since it helps with assigning users to tasks.

Keyrxng commented 1 month ago

Sure, maybe one of the following:

Whatever the repo gets called I'll change my code references to

gentlementlegen commented 1 month ago

Related repository: https://github.com/ubiquibot/command-start-stop