ubiquibot / production

0 stars 1 forks source link

`0` Multiplier - No Explanation #16

Closed 0x4007 closed 1 year ago

0x4007 commented 1 year ago

The bot should ALWAYS return a comment to explain its behavior.

I requested that the architecture for the handlers should be modified so that it ALWAYS returns a message, or at least a default generic message, so that we know if the bot is having issues or is down.

I have my multiplier set to 0. The bot should say something like "Skipping generating a payment permit because assignee's payment multiplier is 0."

https://github.com/ubiquity/ubiquity-dollar/issues/722

ubiquibot[bot] commented 1 year ago

Permit generation skipped since this issue didn't qualify as bounty

ubiquibot[bot] commented 1 year ago

If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!

0x4007 commented 1 year ago

@0xcodercrane there's no changes associated so this shouldn't be marked as completed.

0x4007 commented 1 year ago

@0xcodercrane can you link a pull request or at least a commit for auditing?

0xcodercrane commented 1 year ago

@0xcodercrane can you link a pull request or at least a commit for auditing?

hard to pick up it right now. but we can audit here by doing a QA

0xcodercrane commented 1 year ago

/start

ubiquibot[bot] commented 1 year ago

Deadline Sat, 12 Aug 2023 07:34:50 UTC
Registered Wallet 0x00868BB3BA2B36316c2fc42E4aFB6D4246b77E46

Tips:

0xcodercrane commented 1 year ago

/help

ubiquibot[bot] commented 1 year ago

Available commands


- /start: Assign the origin sender to the issue automatically.
- /stop: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /query: Comments the users multiplier and address
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0x0000000000000000000000000000000000000000
  ex2: /wallet vitalik.eth
0xcodercrane commented 1 year ago

/multiplier @0xcodercrane 0 "QA"

ubiquibot[bot] commented 1 year ago

Successfully changed the payout multiplier for @0xcodercrane to 0. The reason provided is "QA".

ubiquibot[bot] commented 1 year ago

Refusing to generate the payment permit because @0xcodercrane's payment multiplier is 0

If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!
0xcodercrane commented 1 year ago

Refusing to generate the payment permit because @0xcodercrane's payment multiplier is 0

If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!

@pavlovcik