ubiquibot / production

0 stars 1 forks source link

Hot fix: Automatic Assign on Opened Pull Request (Assigned to Unrelated Task!) #34

Closed 0x4007 closed 1 year ago

0x4007 commented 1 year ago

I was working on https://github.com/ubiquity/ubiquibot/issues/595 and opened up a few pull requests because I need to change several repositories' UbiquiBot configs. After opening up my third pull request https://github.com/ubiquity/ubiquity-dollar/pull/751 I was assigned to an unrelated issue: https://github.com/ubiquity/ubiquity-dollar/pull/595

I assume this has something to do with the fact that the issue number (595) is the same across both repositories. Perhaps the feature did not accomodate for cross repository issue tracking. Please diagnose and fix.

0x4007 commented 1 year ago

@wannacfuture you're great at hot fixes is this interesting for you?

wannacfuture commented 1 year ago

/help

ubiquibot[bot] commented 1 year ago

Available commands


- /start: Assign the origin sender to the issue automatically.
- /stop: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /query: Comments the users multiplier and address
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0x0000000000000000000000000000000000000000
  ex2: /wallet vitalik.eth
ubiquibot[bot] commented 1 year ago

Do you have any updates @wannacfuture? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Wed Aug 09 2023 23:57:36 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 1 year ago

@wannacfuture - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Wed Aug 09 2023 23:57:36 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 1 year ago

@wannacfuture - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Wed Aug 09 2023 23:57:36 GMT+0000 (Coordinated Universal Time)

wannacfuture commented 1 year ago

let me handle this. Mr.Bot!

wannacfuture commented 1 year ago

Hmmm, while investigating this issue some quick questions for you, @pavlovcik Your example pull request says it will resolve an issue on another repo.

Of course it will be possible to assigne pr opener to other repo's issue forcely. But I'm not too sure if its right behaviour.

lets assume that we opened the pr and it says it will resolve an issue on other repo(this repo hasn't installed our bot) we will assignee the pr opener to that issue. But maybe the repo owner doesn't want to assignee people to his issue automatically.

Also, technically speaking, to assignee the hunter to other repo's issue we will need that repo's owner name or something(maybe it can be possible if we do more research about octokit). image

I may be wrong. RFC

wannacfuture commented 1 year ago

So, IMO, we should check if the pr is trying to resolve the issue on the same repo or other repo of same orgnization then automatically assign the pr opener to the issue.

rfc, @pavlovcik

0x4007 commented 1 year ago

But maybe the repo owner doesn't want to assignee people to his issue automatically

Not possible the bot wouldn't have permissions to

ubiquibot[bot] commented 1 year ago

Do you have any updates @wannacfuture? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Thu Aug 17 2023 02:53:11 GMT+0000 (Coordinated Universal Time)

0x4007 commented 1 year ago

I will start posting all of these fixes on the @ubiquity/ubiquibot repository in the future. I can't easily transfer this one now.

ubiquibot[bot] commented 1 year ago

@wannacfuture - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Thu Aug 17 2023 02:53:11 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 1 year ago

Permit generation skipped because the issue was not closed as completed

If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!
0x4007 commented 1 year ago

Moved to https://github.com/ubiquity/ubiquibot/issues/666