search

ubiquity-os-marketplace / command-wallet

Commands related to wallet update and query.
0 stars 9 forks source link

feat: command wallet #2

Closed gentlementlegen closed 4 months ago

gentlementlegen commented 4 months ago

Resolves https://github.com/ubiquibot/plugins-wishlist/issues/23

gentlementlegen commented 4 months ago

QA run: https://github.com/Meniole/command-wallet/issues/5#issuecomment-2188886983

gentlementlegen commented 4 months ago

/wallet @gentlementlegen

ubiquibot[bot] commented 4 months ago 
# Skipping to register a wallet address because both address/ens doesn't exist
rndquu commented 4 months ago

@gentlementlegen Getting this error when running the plugin in the "worker" mode on a completely fresh (i.e. empty) DB instance with production schema. What am I doing wrong?

gentlementlegen commented 4 months ago

@rndquu what schema did you use to run and migrate the local DB?

rndquu commented 4 months ago

@rndquu what schema did you use to run and migrate the local DB?

This one https://github.com/ubiquity/ubiquibot/tree/12b702d6a2ea7e637329c1472a8bbb0be853bf8b/supabase/migrations

rndquu commented 4 months ago

@gentlementlegen Could you merge https://github.com/gentlementlegen/command-wallet/pull/1 ?

gentlementlegen commented 4 months ago

@rndquu The problem should be solved now, please let me know.

rndquu commented 4 months ago

@gentlementlegen Check this comment which registers a none checksummed address. Some libs may not handle such addresses correctly. Perhaps it makes sense to convert addresses to their checksummed versions on saving to DB?

Otherwise works fine.

gentlementlegen commented 4 months ago

@rndquu It seems to also be that way in the current version of the bot. I added a checksum.