ubiquity-os-marketplace / daemon-merging

Automatically merges pull-requests that do not have activity beyond a certain deadline.
0 stars 8 forks source link

automated merging not working if total reviewers is under the minimum reviewer quota #16

Open gentlementlegen opened 2 months ago

gentlementlegen commented 2 months ago

There is a scenario where a pull-request can have all the validations from the reviewers but won't get merged because the amount of reviewers is under the amount of required reviewers.

Example

A review has 2 validations out of 2 reviewers, but 3 are required.

Possible solutions

Merge when 100% of reviewers validated

Pros:

Cons:

Post a message saying that the PR can be merged, but requires n more reviewers

Pros:

Cons:

Partially relates to #5