Auto merge if all requested reviews are approved

ubiquity-os-marketplace / daemon-merging

Automatically merges pull-requests that do not have activity beyond a certain deadline.

0 stars 7 forks source link

Auto merge if all requested reviews are approved #5

Open 0x4007 opened 2 months ago

0x4007 commented 2 months ago

Mixed feelings on this because GitHub has this feature already, but it must be manually enabled per every repository which is tedious.

This seems like a simple example of when it can automatically merge with no risk:

https://github.com/ubiquibot/command-start-stop/pull/18#pullrequestreview-2203939804

At least our improvement should allow a threshold i.e. 2/3 requested reviews approved, so automatically merge.

gentlementlegen commented 2 months ago

We could consider having the plugin going through every repo and set the settings accordingly. Does this support giving delays as we do (wait for 7 days for example) and different rules based on the rule of the pull-request author?

0x4007 commented 2 months ago

Does this support giving delays as we do (wait for 7 days for example)

This seems useful too. I just don't want to be rebuilding the features that GitHub already has of course!

different rules based on the rule of the pull-request author?

Sure if we can inherit this from the already implemented logic!

gentlementlegen commented 2 months ago

I will look more in details about GitHub capabitlities regarding this feature. What our plugin allows currently is:

check that it is mergeable
check that the CI run is ok
check for the delay based on the association of the user (collaborator, contributor)
check for any kind of activity

If all of these are configurable within GitHub itself, let's transform the plugin to manipulate the configuration of each repo so we don't have to do it manually, because I agree that it is tedious.