Open Keyrxng opened 2 months ago
@Keyrxng Can you please resolve the conflicts?
QA: https://github.com/ubq-testing/assistive-pricing/actions/runs/11088257095/job/30807939009
I use the worker for local testing but this is now an action plugin after this PR.
Auth:
Pre: 3x
Post: 3x
Pre: 10x
Post: 10x
The logic right now is like this:
globalConfigUpdate
omitted, we simply update the repo labels and we do not update or remove labels from tasks.About number one, with it omitted, should this feature update currently priced tasks to the new bracket?
About two, should all time and priority labeled tasks have a price label applied to them? Or should they remain unpriced if they were unpriced before the run?
@Keyrxng I tested in my org and it seems to work fine, I have a few questions however:
Couldn't we parallelize this more to get it running faster?
Can it be addressed in another task because it'll take some time to work out how best exactly to optimize for speed while trying to avoid both this plugin hitting the secondary and also allowing enough room for other plugins that are operating on the same token to operate effectively.
you mentioned that it should be an Action, but this is currently a Worker, so how do we set this up?
It uses the same env vars so just update the - plugin: <url>
to point at the repo instead.
Can it be addressed in another task because it'll take some time to work out how best exactly to optimize for speed while trying to avoid both this plugin hitting the secondary and also allowing enough room for other plugins that are operating on the same token to operate effectively.
Sure thing.
It uses the same env vars so just update the - plugin:
to point at the repo instead.
What about the commands and the change of labels that have to respond instantly?
What about the commands and the change of labels that have to respond instantly?
You want to split this like telegram-bridge
then and have workflow and worker proxy callbacks and we can have the best of both worlds? There's no way we can optimize things enough that we can run a global update like this on one worker request, I don't see that happening, although I haven't tried it deployed but very unlikely.
If it is no deal breaker that /allow
and label changes take long to respond then no I do not mind, @0x4007 @whilefoo what do you think?
@Keyrxng Can you resolve the conflicts thank you.
If it is no deal breaker that
/allow
and label changes take long to respond then no I do not mind, @0x4007 @whilefoo what do you think?
I already have a solution in the works for ~3 second typescript GitHub action, cold start response time, so I don't think the lag will be an issue in the near future.
Resolves https://github.com/ubiquibot/plugins-wishlist/issues/8
globalConfigUpdate
which containsenable: boolean, excludeRepos:[""]
syncPriceLabelsToConfig()
but it meant moving the typeguard check into the eventName switch case and out of the functionsetPrice
togetPrice
logger.fatal()
callsexcludeRepos
will have many uses but the reason that spurred me to include it was that in my QAdevpool-directory
was being updated with a greenPrice: $10
label when it should have a greyPricing: $10
so that would likely be a default for us to include