Closed gentlementlegen closed 4 months ago
Filename | devDependencies |
---|---|
package.json | @types/jest esbuild eslint-config-prettier eslint-plugin-prettier ts-node |
Filename | unlisted |
---|---|
tests/main.test.ts | @jest/globals |
Filename | exports |
---|---|
src/handlers/pricing-label.ts | labelExists |
src/shared/label.ts | deleteLabel |
src/shared/pricing.ts | calculateDurations |
src/types/typeguards.ts | isIssueEvent |
Filename | types |
---|---|
src/types/env.ts | Env |
src/types/github.ts | Comment Repository WebhookEvent |
src/adapters/supabase/types/database.ts | Tables TablesInsert TablesUpdate Enums |
Filename | Enum | Member |
---|---|---|
src/types/github.ts | UserType | User Organization |
assistive-pricing
now running as a Workerpull_request
Hi @gentlementlegen there is a small commit needed for knip workflow that removes superflous steps. See comment from @rndquu https://github.com/ubiquity/rpc-handler/pull/13#issuecomment-2123006059 . This does not touch any of your changes, I will add this commit to the pull request.
Hi @gentlementlegen there is a small commit needed for knip workflow that removes superflous steps. See comment from @rndquu ubiquity/rpc-handler#13 (comment) . This does not touch any of your changes, I will add this commit to the pull request.
My bad - I checked and you pulled latest changes already, thank you! I also checked on a local workspace
✂️ Excellent, Knip found no issues.
@gentlementlegen I checked out the pr workspace, and I am able to test locally with jest.
Would you mind adding to README.md
steps needed to execute and test the worker locally including supabase setup, if needed? I set supabase .dev.vars
to my instance but I see {"error":"Error: null is not a valid content type"}
when I connect to worker started with yarn worker
command and I am not sure what I am missing and what to expect. Perhaps adding this info would make life easier to anyone who would work on the plugin afterwards. I also see cypress is still a placeholder, will it be used in this repository?
@gitcoindev Thanks for the feedback. I removed Cypress, and added instructions in the README plus a .http
test file. Let me know if that is clear enough or if I should add more instructions.
@gentlementlegen thank you for adding the example, I am approving the pull request from my side.
Resolves #5