search

ubiquity-os-marketplace / text-conversation-rewards

1 stars 27 forks source link

Override any user relation if the user is `ISSUE_ASSIGNEE` #101

Closed gentlementlegen closed 2 months ago

gentlementlegen commented 3 months ago 
          There is a different multiplier for `ISSUE_AUTHOR` and `PULL_AUTHOR` as well as `PULL_ASSIGNED` and `ISSUE_ASSIGNEE`.

Keyrxng is:

Which is why the second one rewards him. This would imply changing the whole logic to look at the originally assigned user to the issue from the PR and then consider the relationship to be ISSUE_ASSIGNED to override the PULL_COLLABORATOR. I do not know how v1 worked on this regard (with the bug it had it would reward everything regardless).

Originally posted by @gentlementlegen in https://github.com/ubiquity/devpool-directory-bounties/issues/31#issuecomment-2309734697

Overall, priority of statuses should be checked, and the highest relation status selected to apply the final rewards. In this scenario, since the user is ISSUE_ASSIGNEE at the time of the reward, that user should not be eligible for any reward.

0x4007 commented 2 months ago

I think we decided to defer this

ubiquity-os[bot] commented 2 months ago 
# Issue was not closed as completed. Skipping.