ubiquity-os-marketplace / text-conversation-rewards

1 stars 27 forks source link

fix: use issue.node_id for permit nonces #108

Closed rndquu closed 2 months ago

rndquu commented 2 months ago

Resolves https://github.com/ubiquibot/permit-generation/issues/46

QA (development branch, old buggy behavior): https://github.com/rndquu-org/my-repo-1/issues/1#issuecomment-2324404387: nonce=78893650957373058525222459826056873078870981337600027323707876018366845390587 https://github.com/rndquu-org/my-repo-2/issues/1#issuecomment-2324409653: nonce=78893650957373058525222459826056873078870981337600027323707876018366845390587

QA (fix/nonce-generation branch): https://github.com/rndquu-org/my-repo-1/issues/1#issuecomment-2338224876: nonce=47174999346132534354494673705511461942918468951327270802916300108996236752932 https://github.com/rndquu-org/my-repo-2/issues/1#issuecomment-2338233348: nonce=83029153680898263555035957871388564685254995512260384748899620589901226451761

In the 1st case (QA for development branch) nonces are the same because issue number is used for nonce generation (not issue.id or issue.node_id). Hence 2 issues with the same issue number across 2 different repositories have equal nonces.

In the 2nd case (QA for fix/nonce-generation branch) we use issue.node_id for nonce generation which is different for any 2 repositories we take.

Notes: