ubiquity-os-marketplace / text-conversation-rewards

1 stars 27 forks source link

feat: element scoring and relevance adjustments #121

Closed gentlementlegen closed 1 month ago

gentlementlegen commented 2 months ago

Resolves #92 QA: https://github.com/Meniole/conversation-rewards/issues/14

gentlementlegen commented 2 months ago

Changes

Might wanna tweak the configuration for element scoring if needed.

gentlementlegen commented 2 months ago

New QA: https://github.com/Meniole/conversation-rewards/issues/14#issuecomment-2372888547

0x4007 commented 1 month ago

New QA: https://github.com/Meniole/conversation-rewards/issues/14#issuecomment-2372888547

The permit link doesn't work.

Also I realize that most defaults should be set to 0 probably. It seems like your default scores are very high.

Off hand what I recall from version one:

$5: img, code, a $1: ol, ul, h1-6 $0.5: li $0.1: word counter, $0: blockquote, bold[^1^]

Please fix defaults and ensure permit links are working

[^1^]: We would also exclude the word count from them

gentlementlegen commented 1 month ago

@0x4007 You can check the new defaults here: https://github.com/ubiquity-os-marketplace/conversation-rewards/pull/121/commits/41c68d827c66094ef4c92da2fcc8d66ef87005b9

Permits are not working because I didn't provide a valid key.

0x4007 commented 1 month ago

Permits are not working because I didn't provide a valid key.

We should throw an error for this instead of generating a fake link.

gentlementlegen commented 1 month ago

@0x4007 I think we should just not post the link, but it is possible through the configuration to disable the permits but have everything else running. It is actually handy for testing and eventually to use within a sandbox, also will be useful for https://github.com/ubiquity-os-marketplace/conversation-rewards/issues/102 to do partial runs. I will remove the regex and update the PR.