Don't Render Rewards If Multiple Pulls Are Linked

[0x4007]

Sometimes we have complex tasks that require multiple pulls across multiple repositories. When one is merged, and others are still open, the rewards should not generate.

• Check if there are other open pulls against the issue when issues.closed occurs.
• If there are open pulls, abort rewards generation.

Context/example: https://github.com/ubiquity/.github/issues/115

[gentlementlegen]

Good idea, and we also should make sure that the pull-request authors are within the assignees list, or that users who open a PR against an issue where there are not assigned gets closed instantly (I think it is the case) to avoid having open issues linked that will never get merged.

[gentlementlegen]

@0x4007 Should we add a warning that the conversation-rewards plugin is awaiting on other tasks to be closed when skipping for this reason? Also I think we should consider drafts as blocking too. Basically anything not closed should stop the generation.

Also it seems there is not way to prevent an issue close when a linked pull-request is closed, so not sure if we shall reopen it every time: https://github.com/orgs/community/discussions/17308

[gentlementlegen]

/start

[ubiquity-os[bot]]

@gentlementlegen the deadline is at Thu, Sep 26, 10:39 AM UTC

[0x4007]

Issue close is fine just don't generate the permits and throw a warning for it.

[gentlementlegen]

I think it would be better to reopen it every time for the following reasons:

• the plugin runs on issue close, so if we do not reopen we will have to also make it run on pull-request close which will change a lot of the code
• the issue won't show inside the assigned issues within GitHub for the user so easy for the user to forget about it
• the reminders wouldn't run on a closed issue

[gentlementlegen]

@0x4007 Do you have a template of the warning message you want to see posted when this occurs?

[0x4007]

! All linked pull requests must be closed to generate rewards.  

[ubiquity-os[bot]]

 [ 87.794 WXDAI ] 

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	75
Issue	Comment	4	12.794
Review	Comment	2	0

Conversation Incentives

Comment	Formatting	Relevance	Reward
Good idea, and we also should make sure that the pull-request au…	2.92 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 53 wordValue: 0.1 result: 2.92	0.8	2.336
@0x4007 Should we add a warning that the conversation-rewards pl…	4.06 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 78 wordValue: 0.1 result: 4.06	0.9	3.654
I think it would be better to reopen it every time for the follo…	6.6 content: content: p: score: 0 elementCount: 4 ul: score: 1 elementCount: 1 li: score: 0.5 elementCount: 3 result: 2.5 regex: wordCount: 79 wordValue: 0.1 result: 4.1	0.85	5.985
@0x4007 Do you have a template of the warning message you want t…	1.17 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 18 wordValue: 0.1 result: 1.17	0.7	0.819
Resolves #128Depends on #121QA: https://github.com/Meniole/c…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 16 wordValue: 0 result: 0	0.2	-
I realized while testing this that there is a part that maybe we…	4.5 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 39 wordValue: 0.2 result: 4.5	0.8	-

 [ 18.826 WXDAI ] 

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	15.06
Issue	Comment	2	1.688
Review	Comment	3	2.078

Conversation Incentives

Comment	Formatting	Relevance	Reward
Sometimes we have complex tasks that require multiple pulls acro…	5.02 content: content: p: score: 0 elementCount: 4 ul: score: 1 elementCount: 1 li: score: 0.5 elementCount: 2 result: 2 regex: wordCount: 55 wordValue: 0.1 result: 3.02	1	15.06
Issue close is fine just don't generate the permits and throw a …	2.11 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0.2 result: 2.11	0.8	1.688
```diff! All linked pull requests must be closed to…	0 content: content: pre: score: 0 elementCount: 1 result: 0 regex: wordCount: 0 wordValue: 0.2 result: 0	0.9	-
Based on QA seems fine.	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.2	0.078
I thought our logger abstracts all this away. Why not just add a…	2.1 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 36 wordValue: 0.1 result: 2.1	0.7	1.47
All of them but it should only render the rewards when the last …	1.06 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06	0.5	0.53