Closed whck6 closed 1 month ago
@0x4007 Do you mind helping me check?
You need to also change the logic that applies the url to the request. Test with anthropic api using only the config then you'll understand what I'm saying.
You need to also change the logic that applies the url to the request. Test with anthropic api using only the config then you'll understand what I'm saying.
Perhaps we could try to delete the property of endpoint
from here because we're just using openai
for the purpose, and openai
of the baseURL
should be dependent on installed version. What do you think?
I think so too but not sure why this was implemented in the first place @gentlementlegen @EresDev @whilefoo
But ideally it should be configurable like most other implementations. It should allow us to easily switch to anthropic
But ideally it should be configurable like most other implementations. It should allow us to easily switch to anthropic
If so. Should we determine which will anthropic support first? And I consider that thing might be another task.
Sure different task is fine but anyways this pull isn't complete you need to change the logic how the default value is used. No way this change works and doesn't break the system.
@0x4007 Updated it.
@0x4007 Could you help to review and merge it?
Signed-off-by: Wenhao Ho wh.ho@outlook.com
Resolves #139