search

ubiquity-os-marketplace / text-conversation-rewards

1 stars 27 forks source link

feat: fee value #159

Closed gentlementlegen closed 1 month ago

gentlementlegen commented 1 month ago

Resolves #57 QA: https://github.com/Meniole/conversation-rewards/issues/23#issuecomment-2409044285

gentlementlegen commented 1 month ago

@0x4007 Let me know if you are okay with the display and I will fix the related tests.

gentlementlegen commented 1 month ago

New QA: https://github.com/Meniole/conversation-rewards/issues/23#issuecomment-2413032702 The failing tests are the ones involving the RPCs.

0x4007 commented 1 month ago

New QA: https://github.com/Meniole/conversation-rewards/issues/23#issuecomment-2413032702

The failing tests are the ones involving the RPCs.

Thanks for the QA

As part of a separate task, I think we should consider adding a new column to the table that displays the fee per line item transparently

0x4007 commented 1 month ago

Just noticed the committed compiled js. I'm assuming this is necessary for faster cold start

gentlementlegen commented 1 month ago

@0x4007 Yes otherwise we should have to compile it. I'll have a look at the repo you linked about JS Actions.