fix: multipliers config

ubiquity-os-marketplace / text-conversation-rewards

1 stars 27 forks source link

fix: multipliers config #186

Closed gentlementlegen closed 1 week ago

gentlementlegen commented 1 week ago

This aims to solve the issue where contributor pull-requests get rewards even though we disabled them in the configuration.

The changes are:

set default to 0 for pull request contributor comments
either use the configuration or the defaults but not both, because currently they get merged together which is why they are not properly taken into account

Example for https://github.com/ubiquity-os-marketplace/text-conversation-rewards/issues/175 after fix

gentlementlegen commented 1 week ago

@whilefoo If you want to take a look as well.

gentlementlegen commented 1 week ago

Edit: I noticed the side effect that it removes the default from the manifest which will have side effect on the configuration, I will try to figure out a workaround.

gentlementlegen commented 1 week ago

I will preemptively merge this to be able to generate rewards properly, let me know if changes are needed.