search

ubiquity-os-marketplace / text-conversation-rewards

1 stars 27 forks source link

Include review comments in the final result #61

Closed gentlementlegen closed 2 months ago

gentlementlegen commented 4 months ago

Review comments seem to be ignored when collecting the result, as seen here: https://github.com/ubiquibot/conversation-rewards/issues/22?notification_referrer_id=NT_kwDOAJWkoLMxMDYzNjkzMzUxMjo5ODA3MDA4#issuecomment-2232171245

They should be included for all the users in the final result.

Another example of broken data: https://github.com/ubiquity/rpc-handler/issues/23#issuecomment-2235151802

0x4007 commented 4 months ago

Time estimate? Or perhaps we can make these rolling hotfix tasks official once they saturate a full day's of work?

gentlementlegen commented 4 months ago

@0x4007 Added a time estimate. This was created to split the https://github.com/ubiquibot/conversation-rewards/issues/26 which encapsulates all of the required fixes.

gentlementlegen commented 2 months ago

This was fixed when shipping the v2 with all the changes.

ubiquity-os[bot] commented 2 months ago 
# Issue was not closed as completed. Skipping.