ubiquity-os-marketplace / text-conversation-rewards

1 stars 27 forks source link

User configuration environment instead of checking the values from the environment directly #72

Closed gentlementlegen closed 1 month ago

gentlementlegen commented 4 months ago
          Make sure to load this in at the top of the file, and to throw an error if its missing instead of potentially having this be invalid when its needed. I generally always make a helper function to load all the environment variables right at runtime start, and throw a detailed error if its missing any.

_Originally posted by @0x4007 in https://github.com/ubiquibot/conversation-rewards/pull/58#discussion_r1691159526_

ubiquity-os[bot] commented 2 months ago
! No labels are set.
0x4007 commented 1 month ago

Was trying to use the new Time: <15 Minutes but it doesn't populate

0x4007 commented 1 month ago

/help

ubiquity-os[bot] commented 1 month ago

Available Commands

Command Description Example
/help List all available commands. /help
/allow Allows the user to modify the given label. /allow @user1 label
/query Returns the user's wallet, access, and multiplier information. /query @ubiquibot
/start Assign yourself to the issue. /start
/stop Unassign yourself from the issue. /stop
/wallet Register your wallet address for payments. /wallet ubq.eth
ubiquity-os-beta[bot] commented 1 month ago

 [ 23.1 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask112
IssueSpecification111.1
ReviewComment10
Conversation Incentives
CommentFormattingRelevanceReward
Make sure to load this in at the top of the file, and to throw a…
3.7
content:
  content:
    p:
      score: 0
      elementCount: 2
    em:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 70
  wordValue: 0.1
  result: 3.7
111.1
Resolves #72 Depends on https://github.com/ubiquity-os-marketp…
0
content:
  content: {}
  result: 0
regex:
  wordCount: 12
  wordValue: 0
  result: 0
0.3-

 [ 0 WXDAI ] 

@0x4007
Contributions Overview
ViewContributionCountReward
Conversation Incentives
CommentFormattingRelevanceReward
0x4007 commented 1 month ago

I think it would be simpler to just filter out at the end if a contributor has a 0 score just remove their link and section of the comment @gentlementlegen

gentlementlegen commented 1 month ago

@0x4007 I think this happened because you actually commented but then marked your comment as "off-topic" so didn't get counted in the end.

0x4007 commented 1 month ago

Sure but I'm saying add a filter at the very end for edge cases like this.