ubiquity-os-marketplace / text-conversation-rewards

1 stars 27 forks source link

fix: undefined configuration #75

Closed gentlementlegen closed 3 months ago

gentlementlegen commented 4 months ago

Resolves #65

Depends on #68

gentlementlegen commented 4 months ago

Changes

This pull-request allows for the configuration to handle default and missing items within incentives so it becomes easier to set a configuration.

Supported values are:

incentives:

That would have all modules disabled (because none are present);

incentives:
    userExtractor: {}

To individually enable modules with their defaults;

incentives:
    githubComment:
        enabled: true
        post: true
        debug: false

to set values for a module.

QA run

Partially set configuration with defaults

0x4007 commented 3 months ago

@gentlementlegen should this be closed?

gentlementlegen commented 3 months ago

@0x4007 I think this will close automatically when https://github.com/ubiquibot/conversation-rewards/pull/68 goes in because it contains it, should be handled by GitHub.