ubiquity-os-marketplace / text-conversation-rewards

1 stars 27 forks source link

Change linked pull request fetch #95

Closed gentlementlegen closed 2 months ago

gentlementlegen commented 3 months ago
          @gentlementlegen it didnt collect any review comments this time.

Originally posted by @0x4007 in https://github.com/ubiquity/devpool-directory-bounties/issues/31#issuecomment-2306908267

My suspicion is that the linked pull-request was not properly fetched. This can be solved by using graphql instead of manually fetching linked events. This might not be the cause of the problem but this is a needed improvement.

0x4007 commented 3 months ago

Honestly doesn't make sense to me though. Never had this problem in development and testing.

gentlementlegen commented 3 months ago

The was a few times when the fetched linked pull-requests were evaluating the wrong comments, which led to my first change with the regex on how we fetched linked PRs. But then, there was a second issue that the comment containing #1234 was also linked. Since no comment was evaluated here my suspicion is that they just didn't get parsed. But that's a first guess I didn't read the logs yet. Either way this can be changed to Graphql so it removes tons on code and potential errors in favor of the official API with no tricks to get linked PRs.

gentlementlegen commented 3 months ago

Example of another plugin implementing GraphQl search: https://github.com/ubiquibot/user-activity-watcher/pull/15#issuecomment-2296003711

ubiquity-os[bot] commented 3 months ago

[ 116.46 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Task 1 75
Issue Specification 1 19.5
Issue Comment 2 21.96
Review Comment 2 0
Conversation Incentives
Comment Formatting Relevance Reward
@gentlementlegen it didnt collect any review comments this time. …
19.5
content:
  p:
    symbols:
      \b\w+\b:
        count: 65
        multiplier: 0.1
    score: 1
  em:
    symbols:
      \b\w+\b:
        count: 16
        multiplier: 0.1
    score: 0
multiplier: 3
1 19.5
The was a few times when the fetched linked pull-requests were e…
21.2
content:
  p:
    symbols:
      \b\w+\b:
        count: 105
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 1
multiplier: 1
0.9 19.08
Example of another plugin implementing GraphQl search: https://g…
3.6
content:
  p:
    symbols:
      \b\w+\b:
        count: 18
        multiplier: 0.2
    score: 1
multiplier: 1
0.8 2.88
Resolves #95 QA: - https://github.com/ubiquity/devpool-direct…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 3
        multiplier: 0
    score: 1
  ul:
    symbols:
      \b\w+\b:
        count: 70
        multiplier: 0
    score: 1
  li:
    symbols:
      \b\w+\b:
        count: 35
        multiplier: 0
    score: 1
multiplier: 0
0.3 -
I think ideally we should use codegen or similar tools to get th…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 32
        multiplier: 0.2
    score: 1
multiplier: 0
1 -

[ 0.82 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 1 0.32
Review Comment 1 0.5
Conversation Incentives
Comment Formatting Relevance Reward
Honestly doesn't make sense to me though. Never had this problem…
1.6
content:
  p:
    symbols:
      \b\w+\b:
        count: 16
        multiplier: 0.1
    score: 1
multiplier: 1
0.2 0.32
I don't know GraphQL
0.5
content:
  p:
    symbols:
      \b\w+\b:
        count: 5
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.5

[ 5.9 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Review Comment 2 5.9
Conversation Incentives
Comment Formatting Relevance Reward
Looks okay to me
0.4
content:
  p:
    symbols:
      \b\w+\b:
        count: 4
        multiplier: 0.1
    score: 1
multiplier: 1
1 0.4
Since the `graphql.config.yml` should provide static typ…
5.5
content:
  p:
    symbols:
      \b\w+\b:
        count: 52
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 3
        multiplier: 0.1
    score: 1
multiplier: 1
1 5.5