ubiquity-os / permit-generation

A standalone module to generate permits.
1 stars 19 forks source link

Optional NFT Types #88

Open 0x4007 opened 3 weeks ago

0x4007 commented 3 weeks ago

We should fix the type checks in another pull and make these optional probably?

_Originally posted by @0x4007 in https://github.com/ubiquity-os/permit-generation/pull/69#discussion_r1797709276_

Do it with TypeBox

rajiknows commented 3 weeks ago

cant find that file

0x4007 commented 3 weeks ago

@whilefoo rfc

whilefoo commented 2 weeks ago

https://github.com/ubiquity-os/permit-generation/blob/development/src/types/env.ts

luisantoniocrag commented 2 weeks ago

/start

ubiquity-os-beta[bot] commented 2 weeks ago

@luisantoniocrag the deadline is at Sat, Oct 19, 8:03 AM UTC

luisantoniocrag commented 2 weeks ago

If I understood correctly, it is to make those two variables optional and fix the check that causes that change, right?

luisantoniocrag commented 2 weeks ago

/wallet 0xbF5aBF239267DDF3e99aB1aEa20626f449368fBf

ubiquity-os-beta[bot] commented 2 weeks ago

+ Successfully registered wallet address
imabutahersiddik commented 1 week ago

/start

ubiquity-os-beta[bot] commented 1 week ago
! This issue is already assigned. Please choose another unassigned task.