search

ubiquity-os / permit-generation

A standalone module to generate permits.
1 stars 19 forks source link

Convert plugin to cloudflare worker #92

Open rndquu opened 1 month ago

rndquu commented 1 month ago

Depends on https://github.com/ubiquity-os/permit-generation/issues/68

Related comments:

As far as I understand the reasons to convert this plugin from github action to cloudflare woker are:

  1. It fits with the pay.ubq.fi rolled up feature because cloudflare functions located at pay.ubq.fi can call API endpoint and can not call (as well as get result) a github action
  2. Other plugins (or kernel) will be able to call "generate permit" endpoint

So as a part of this issue we should:

rndquu commented 1 month ago

@0x4007 Could you make me an owner of https://github.com/ubiquity-os? I want to put time estimates and perform reviews.

Atharva-Kanherkar commented 3 weeks ago

@rndquu Is this open to work for anyone? I'd like to work on this. But I would need two three days to complete the PR.

rndquu commented 3 weeks ago

@rndquu Is this open to work for anyone?

Yes

Atharva-Kanherkar commented 3 weeks ago

/start

ubiquity-os-beta[bot] commented 3 weeks ago
Deadline Sun, Oct 27, 8:13 AM UTC
Beneficiary 0x5aA24603E7Ef2D14dE1d1FD6bafF952c16636217

[!TIP]

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.
Atharva-Kanherkar commented 3 weeks ago

This seems more of a research topic right now. I would move to some good first issues right now, And if no one is working on this, I would start working on this too. Seems more of a hard task at hand given I am newbie here. I would apologize for any inconvenience caused.

Atharva-Kanherkar commented 3 weeks ago

/stop

Keyrxng commented 3 weeks ago

/start

ubiquity-os-beta[bot] commented 3 weeks ago
Deadline Sun, Oct 27, 12:02 PM UTC
Beneficiary 0xAe5D1F192013db889b1e2115A370aB133f359765

[!TIP]

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.
Keyrxng commented 3 weeks ago

https://github.com/ubiquity-os/permit-generation/pull/1

I first ported this over as an action, it then became a worker, and then back to an action in the same PR back in Feb (never credited for it).

During that process if you recall @rndquu the conversation on TG regarding my need to replace libsodium at that time with tweetnacl?.

I'm hoping I'll find another solution if the problem still exists although I expect it will but if I can't find another approach, is my original method appropriate?

You said:

'overall not really tied to libsodium, we need any CSPRNG for node and browser, in order to use a new CSPRNG we need to:

  1. Update keygen.ubq.fi using new lib
  2. Update permit-generation on bot side unsure if tweetnacl is CSPRNG - easier to find a way to use current impl with libsodium`
  1. All decryption bot side stems from this package now, so if I need to we just need to do 1.

I'll aim to use libsodium as there are worker friendly builds, I tried them back then but it's worth another shot tho I'll give clear QA as to why if it's not possible.

ubiquity-os-beta[bot] commented 3 weeks ago 
! This issue is already assigned. Please choose another unassigned task.
ubiquity-os-beta[bot] commented 3 weeks ago 
! You are not assigned to this task
Keyrxng commented 3 weeks ago

@gentlementlegen what on earth lmao. I never invoked any commands or triggered any events in here. Haven't tied a PR to it or nothing. Just sort of went off on one.

gentlementlegen commented 3 weeks ago

@Keyrxng seems the user who invoked this is hhio618 and that the comments were deleted which is why it looks like this.

ubiquity-os-beta[bot] commented 1 week ago

Passed the deadline and no activity is detected, removing assignees: @Keyrxng.

ubiquity-os-beta[bot] commented 2 days ago

@Keyrxng the deadline is at Thu, Nov 21, 4:11 PM UTC

ubiquity-os-beta[bot] commented 2 days ago

A new workroom has been created for this task. Join chat