Open Keyrxng opened 6 days ago
src/plugin.ts
, src/worker.ts
, src/helpers/validator.ts
Filename | devDependencies |
---|---|
package.json | @mswjs/data br/>`@typescript-eslint/eslint-plugin`<br/@typescript-eslint/parser ts-node tsx |
Filename | unlisted |
---|---|
tsconfig.json | node |
Filename | binaries |
---|---|
.github/workflows/publish-package.yml | publish |
The bulk of the refactoring is done and tests are passing so it can be reviewed from here. One last change coming which is fixing encryption/decryption.
libsodium
or use one of the various versions (libsodium-wrappers-sumo, libsodium, -sumo, etc)PermitRequest
. I reckon I'll just have the invoker pass in the metadata object directly and build the keys and values from itWill do a complete overview tomorrow after the package problem is resolved
@UbiquityOS Summarize my pull request
This pull request implements the @ubiquity-os/permit-generation
module, designed to isolate the bot's payment capabilities. Key features of this implementation include:
Module Integration: The module can be directly invoked from other plugins within the ecosystem, facilitating seamless interactions.
Input Definition: It introduces the PermitGenerationInput
type, which accepts an array of permit descriptors containing fields such as username
, amount
, address
, task
, transfer
, and evmPrivateKeyEncrypted
.
Data Validation:
public.permits
table within Supabase.Permit Generation: After successful validation, the module generates an array of permits, which can be converted into URLs for payment processing via pay.ubq.fi
.
Configuration and Security: Utilizes dotenv
for managing environment variables and libsodium
for handling cryptographic operations, ensuring secure and efficient processing.
Code Quality and Testing: Maintains high code standards with ESLint and Prettier, employs Husky for git hooks and commit linting, and includes Jest-based testing to ensure reliability.
Issue Resolution: This PR resolves issue #92 by addressing critical aspects of the permit generation process, ensuring the module operates as intended within the broader system.
Overall, this pull request lays the groundwork for robust payment handling within the UbiquityOS ecosystem, leveraging TypeScript for development and integrating essential tools and libraries to maintain quality and security.
/ask
is not working as it should be.
Pull Request
in the header but appears as Issue
Please see this run
/ask
is not working as it should be.
- Hallucinating against the spec because it never pulled the spec in.
- The README inside the conversation block without distinction makes it appear as if it's part of the current conversation which should state
Pull Request
in the header but appears asIssue
- It looks like it hasn't pull in the PR diff at all
Please see this run
@sshivaditya2019 I looked through the logs and I don't understand how it created that spec based on real snippets of text from other unrelated places.
! Error: HttpError: Resource not accessible by integration - https://docs.github.com/rest/issues/comments#create-an-issue-comment
@Keyrxng, this task has been idle for a while. Please provide an update.
@Keyrxng, this task has been idle for a while. Please provide an update.
Just pushed code for 12 days straight, taking 2 days off (this is the 2nd)
I looked through the logs and I don't understand how it created that spec based on real snippets of text from other unrelated places.
@0x4007 it's not real snippets of text in the logs. It's the readme which you wrote for this plugin aaages ago. It's literally just my comments and the readme that was pulled into the formattedChat
. I'm unsure what embeddings search returned (unless you saw those SB logs or something) as they are not logged in that linked action run.
I searched some of the sentences and found results on our GitHub from various repos and various commenters.
I searched some of the sentences and found results on our GitHub from various repos and various commenters.
Ah you mean pieces mentioned in the LLM response my bad I was meaning the formatted chat log, that goes back to us not seeing what embeddings search is actually returning, a quick fix is to log them independently so they can be assessed too. We should see the format chat, the embeddings results, the final ctx window and response I think.
@Keyrxng, this task has been idle for a while. Please provide an update.
Returned my original logic I had in the beginning for handling decryption, relates to this comment.
Looked more into TweetNaCl and left a comment in worker.ts
, safe to use. Unit tests were refactored to a point were anything wrong in the logic would result in failed tests and all are passing.
All features as per the spec have been implemented. A plugin can send a request as it normally does so long as it passes in one of two of the permit schema described in plugin-config.ts
. Spec needs expanded upon potentially?
I'll produce kernel QA if required, but what's needed to complete the task outwith that? Is this going to be used immediately by text-conversation
or is it being built into the kernel and each plugin sends the request back and the kernel requests this plugin via endpoint or via a trad plugin?
QA: worker returning a permit locally
Resolves #92