ubiquity-os / permit-generation

A standalone module to generate permits.
1 stars 19 forks source link

Feat/workerize #96

Open Keyrxng opened 6 days ago

Keyrxng commented 6 days ago

Resolves #92

github-actions[bot] commented 6 days ago

Unused files (3)

src/plugin.ts, src/worker.ts, src/helpers/validator.ts

Unused devDependencies (5)

Filename devDependencies
package.json @mswjs/databr/>`@typescript-eslint/eslint-plugin`<br/@typescript-eslint/parser
ts-node
tsx

Unlisted dependencies (1)

Filename unlisted
tsconfig.json node

Unlisted binaries (1)

Filename binaries
.github/workflows/publish-package.yml publish
Keyrxng commented 5 days ago

The bulk of the refactoring is done and tests are passing so it can be reviewed from here. One last change coming which is fixing encryption/decryption.

Will do a complete overview tomorrow after the package problem is resolved

Keyrxng commented 5 days ago

@UbiquityOS Summarize my pull request

ubiquity-os-beta[bot] commented 5 days ago

This pull request implements the @ubiquity-os/permit-generation module, designed to isolate the bot's payment capabilities. Key features of this implementation include:

Overall, this pull request lays the groundwork for robust payment handling within the UbiquityOS ecosystem, leveraging TypeScript for development and integrating essential tools and libraries to maintain quality and security.

Keyrxng commented 5 days ago

/ask is not working as it should be.

  1. Hallucinating against the spec because it never pulled the spec in.
  2. The README inside the conversation block without distinction makes it appear as if it's part of the current conversation which should state Pull Request in the header but appears as Issue
  3. It looks like it hasn't pull in the PR diff at all

Please see this run

0x4007 commented 3 days ago

/ask is not working as it should be.

  1. Hallucinating against the spec because it never pulled the spec in.
  2. The README inside the conversation block without distinction makes it appear as if it's part of the current conversation which should state Pull Request in the header but appears as Issue
  3. It looks like it hasn't pull in the PR diff at all

Please see this run

@sshivaditya2019 I looked through the logs and I don't understand how it created that spec based on real snippets of text from other unrelated places.

ubiquity-os-beta[bot] commented 3 days ago
! Error: HttpError: Resource not accessible by integration - https://docs.github.com/rest/issues/comments#create-an-issue-comment
ubiquity-os-beta[bot] commented 3 days ago

@Keyrxng, this task has been idle for a while. Please provide an update.

Keyrxng commented 3 days ago

@Keyrxng, this task has been idle for a while. Please provide an update.

Just pushed code for 12 days straight, taking 2 days off (this is the 2nd)

Keyrxng commented 2 days ago

I looked through the logs and I don't understand how it created that spec based on real snippets of text from other unrelated places.

@0x4007 it's not real snippets of text in the logs. It's the readme which you wrote for this plugin aaages ago. It's literally just my comments and the readme that was pulled into the formattedChat. I'm unsure what embeddings search returned (unless you saw those SB logs or something) as they are not logged in that linked action run.

0x4007 commented 2 days ago

I searched some of the sentences and found results on our GitHub from various repos and various commenters.

Keyrxng commented 2 days ago

I searched some of the sentences and found results on our GitHub from various repos and various commenters.

Ah you mean pieces mentioned in the LLM response my bad I was meaning the formatted chat log, that goes back to us not seeing what embeddings search is actually returning, a quick fix is to log them independently so they can be assessed too. We should see the format chat, the embeddings results, the final ctx window and response I think.

ubiquity-os-beta[bot] commented 1 day ago

@Keyrxng, this task has been idle for a while. Please provide an update.

Keyrxng commented 1 day ago

Returned my original logic I had in the beginning for handling decryption, relates to this comment.

Looked more into TweetNaCl and left a comment in worker.ts, safe to use. Unit tests were refactored to a point were anything wrong in the logic would result in failed tests and all are passing.

All features as per the spec have been implemented. A plugin can send a request as it normally does so long as it passes in one of two of the permit schema described in plugin-config.ts. Spec needs expanded upon potentially?

I'll produce kernel QA if required, but what's needed to complete the task outwith that? Is this going to be used immediately by text-conversation or is it being built into the kernel and each plugin sends the request back and the kernel requests this plugin via endpoint or via a trad plugin?

QA: worker returning a permit locally Screenshot 2024-11-03 214135