Closed Keyrxng closed 3 months ago
very basic rn but gets the core stuff needed to get up and running quickly
adding specific utils etc will be easier once all of V1 has been ported/I have more exp porting/creating plugins. It started to quickly bloat so I kept it thin for now
/start
Just tried to transfer my repo to the org but no joy, I'll PR it against the repo once created.
Deadline | Sun, May 19, 1:35 PM UTC |
Registered Wallet | 0xAe5D1F192013db889b1e2115A370aB133f359765 |
/wallet 0x0000...0000
if you want to update your registered payment wallet address.@Keyrxng Please move the work to the following repository https://github.com/ubiquibot/plugin-template
Also side note, the template should include the Worker setup as well I suppose.
@Keyrxng How is this coming along? Would be neat to have it for future plugins.
@gentlementlegen I'll get on it, I was holding off because of https://github.com/ubiquibot/plugins-wishlist/issues/9 not moving along thinking that the reason is because the direction for workers wasn't completely decided on.
I also wasn't sure if I was approaching it right either, but I'll bring over what I have.
We have https://github.com/ubiquibot/command-query-user which was set up as a worker. I think the template should contain both setups, since they can coexist with no issue.
@gentlementlegen can you add an empty readme to the repo so I can fork it easier please bud
GH UI not registering my git cloned empty repo even with upstream etc set right, I think GH UI is the only other way as GH desktop isn't picking up on it being a forked clone either, but did warn that I had forked an empty repo.
@Keyrxng Good to go
+ Evaluating results. Please wait...
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 9.487 |
Issue | Comment | 4 | 11.778 |
Review | Comment | 17 | 67.336 |
View | Contribution | Count | Reward |
---|
Comment | Formatting | Relevance | Reward |
---|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 4 | 7.9 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
@Keyrxng Please move the work to the following repository https... | 2.9 | 0.56 | 2.9 |
@Keyrxng How is this coming along? Would be neat to have it for ... | 1.5 | 0.72 | 1.5 |
We have https://github.com/ubiquibot/command-query-user which wa... | 3.1 | 0.81 | 3.1 |
@Keyrxng Good to go... | 0.4 | 0.625 | 0.4 |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 50.4 |
Issue | Comment | 3 | 36.8 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Package all of the common and required parts needed to build a p... | 50.4h5: count: 1 score: "1" words: 6 a: count: 2 score: "2" words: 4 li: count: 10 score: "10" words: 151 code: count: 2 score: "2" words: 4 | 1 | 50.4 |
- https://github.com/Keyrxng/ubiquibot-plugin-template very b... | 12li: count: 1 score: "1" words: 7 | 0.57 | 12 |
@gentlementlegen I'll get on it, I was holding off because of ht... | 11.6 | 0.745 | 11.6 |
@gentlementlegen can you add an empty readme to the repo so I ca... | 13.2 | 0.49 | 13.2 |
@0x4007 @gentlementlegen, shouldn't it be the case that if someone creates the issue and then also completes it then they should receive whichever reward is the highest between the task price and task creation reward + comments?
EDIT:
I think it's happened because the bot rogue unassigned me so the permit was created without an assignee on the issue
EDIT 2:
A check should probably be added to the permit generation so that it doesn't generate a permit without an assignee attached to the issue. It should either assign the author of the PR that is being closed as complete automatically or alert the person merging by tagging them in a comment or something?
EDIT 3:
I'm going to claim it as-is because I need it and in case I am wrong about the circumstance. Hoping that any difference owed (if-any) can be handled (as I know it's once nonce per issue) via direct transfer or a bump on one of my other tasks.
@Keyrxng the deadline is at 2024-06-09T15:27:03.787Z
+ Evaluating results. Please wait...
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 4 | 7.9 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
@Keyrxng Please move the work to the following repository https... | 2.9 | 0.58 | 2.9 |
@Keyrxng How is this coming along? Would be neat to have it for ... | 1.5 | 0.65 | 1.5 |
We have https://github.com/ubiquibot/command-query-user which wa... | 3.1 | 0.695 | 3.1 |
@Keyrxng Good to go... | 0.4 | 0.2 | 0.4 |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 50.4 |
Issue | Task | 1 | 150 |
Issue | Comment | 4 | 70.8 |
Issue | Comment | 4 | 0 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Package all of the common and required parts needed to build a p... | 50.4h5: count: 1 score: "1" words: 6 a: count: 2 score: "2" words: 4 li: count: 10 score: "10" words: 151 code: count: 2 score: "2" words: 4 | 1 | 50.4 |
- https://github.com/Keyrxng/ubiquibot-plugin-template very b... | 12li: count: 1 score: "1" words: 7 | 0.46 | 12 |
@gentlementlegen I'll get on it, I was holding off because of ht... | 11.6 | 0.725 | 11.6 |
@gentlementlegen can you add an empty readme to the repo so I ca... | 13.2 | 0.28 | 13.2 |
@0x4007 @gentlementlegen, shouldn't it be the case that if someo... | 34 | 0.27 | 34 |
- https://github.com/Keyrxng/ubiquibot-plugin-template very b... | -li: count: 1 score: "0" words: 7 | 0.46 | - |
@gentlementlegen I'll get on it, I was holding off because of ht... | - | 0.725 | - |
@gentlementlegen can you add an empty readme to the repo so I ca... | - | 0.28 | - |
@0x4007 @gentlementlegen, shouldn't it be the case that if someo... | - | 0.27 | - |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 150 |
Issue | Specification | 1 | 4.3855 |
Issue | Comment | 5 | 8.406 |
Review | Comment | 17 | 56.338 |
View | Contribution | Count | Reward |
---|
Comment | Formatting | Relevance | Reward |
---|
@Keyrxng Should be fixed now. The reason why you got unassigned is most likely because you were considered as inactive, but the bot does not update a user status without having any sort of activity on the task.
[ 7.9 WXDAI ]
@gentlementlegen
[ 271.2 WXDAI ]
@Keyrxng
Hotdamn, I expected a difference of ~$80. I had to claim the permit this morning for $87 as I needed it for food (one day I'll be poverty free 🤣).
@0x4007 would you be able to manual the difference this one time and I will not do this again, I'd of been okay losing ~$80 if there was no resolve possible but not ~$190 that's brutal af.
I hear you regarding the bot ejection @gentlementlegen, it was just a thought, it could be a potential new plugin even?
@Keyrxng Yes, working on it: https://github.com/ubiquibot/plugins-wishlist/issues/7
@gentlementlegen I was meaning the specific feature of re-assigning the author of the incoming merge if they are currently not assigned to the assignee and the assignee is null?
e.g. if they have been removed by wildcard/unassign previously but are the rightful PR author when the PR is finally merged. e.g. alternatively, if the assignee is not null. You resolved an issue not too long ago which jordan was assigned to, the merged PR you authored and subsequently you received the payout albeit manually processed after the merge. This new plugin could handle these scenarios and remove the need for reviewers/hunters to double check before generating the permit?
If a user has been removed by wildcard then they'll have had the XP/Karma reductions so being unassigned and then it being merged 1 or 2 weeks later (through either their own fault or due to slow review) has no negative effects.
Other than, an issue appears to be open and workable when in reality it isn't so it circumvents that a bit.
I'm just thinking QOL would be improved
EDIT:
I realise that you may already be including this logic and that is what you meant if so just ignore this 😂
This is a valid point, but I think this scenario is induced by the unassign logic not being accurate. If a user gets a reminder and a notification when they get unassigned, they would have reassigned themselves before the PR was opened / merged. In your case you got unassigned the same second the PR was closed which resulted in this problem. Hopefully this scenario would not be common on the v2, but I'll keep it in mind.
@Keyrxng I sent 150 for the task reward. In the future, consider reviewing the contribution breakdown before accepting to know if something is off. https://gnosisscan.io/tx/0x2d809e7abe91a4751da60483b3c95c19b398a1167872286474dee9ed0110117b
@0x4007 thank you and I will do!
Package all of the common and required parts needed to build a plugin and host a template repo
@ubiquity/configuration
,@ubiquity/logger
?, ...etcImproves DX, streamlines development and with any breaking changes to how plugins are developed they can be kept up-to date in the template's readme.
time estimate: < 1-2 hrs