search

ubiquity-os / plugins-wishlist

0 stars 3 forks source link

Automatic Workflow Deploy #55

Open 0x4007 opened 2 weeks ago

0x4007 commented 2 weeks ago

If no changes were made to any of the .github/workflows/*.yml files then we should automatically run the workflows. This is relevant for QA (build tests, continuous deploys etc.)

0x4007 commented 2 weeks ago

@gentlementlegen how long does it take to make plugins? I assume the core logic of this is only a few lines.

gentlementlegen commented 2 weeks ago

With the SDK it's two lines! However I am not sure to understand your spec.

0x4007 commented 2 weeks ago

The problem is that for many external contributors, a collaborator must manually trigger their workflow runs because that's the default behavior of repositories on GitHub.

The thing is, we rely on our CI for QA so it just slows things down if we have to manually run the workflows every time to build/test/deploy etc

gentlementlegen commented 2 weeks ago

The reason behind it is because it is potentially running malicious code. I think this behavior can be changed in GitHub settings.

gentlementlegen commented 2 weeks ago

image https://github.com/ubiquity-os/plugins-wishlist/settings/actions

0x4007 commented 2 weeks ago

Yes I am aware it can be manually changed for every repo but isn't that annoying to keep track of given that we make a new repo every 1-2 weeks?

gentlementlegen commented 2 weeks ago

You can change this org wise so all subsequent repos will have that same rule defined: https://github.com/organizations/ubiquity-os/settings/actions. Sadly doesn't apply for previously created repos, but a script could be done about that. I think that should solve the problem?

0x4007 commented 2 weeks ago

It might be enough I'm not sure yet