push/check modified base rate on base rate change

gentlementlegen commented 6 months ago

A plugin that will update all the price labels if a base rate change is detected. Should most likely be carried out within https://github.com/ubiquibot/assistive-pricing if not already there.

See code reference

bytegun commented 5 months ago

Can I work on this issue?

jordan-ae commented 5 months ago

/start

ubiquibot[bot] commented 5 months ago




Deadline Mon, May 20, 1:14 PM UTC

Registered Wallet
0x2F05fD58023B0a95d1866aa0A3b672cEf05945c5

Tips:

Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Keyrxng commented 5 months ago

I've already done about 80% of the legwork for this.

The trouble with this @gentlementlegen is that the plugin won't be able to read their org config so cannot process an org wide update.

A repo level update is do-able as it'll be public but I think the spec implies an org-wide label update if the org base rate changes, am I correct in thinking that or did you mean on a per-repo basis?

jordan-ae commented 5 months ago

@Keyrxng Since you've done much of the work already I'll leave it to you then!

jordan-ae commented 5 months ago

/stop

ubiquibot[bot] commented 5 months ago

+ You have been unassigned from the task

Keyrxng commented 5 months ago

@jordan-ae thanks buddy I appreciate it

The repo is private as I've had to consistently log env vars in debugging the situation

0x4007 commented 5 months ago

We can consider making the org config public, although to me it seems like a lazy answer. I'm sure that we can solve auth via the app for that repository.

Keyrxng commented 5 months ago

We can consider making the org config public

That would imply that in order to use secrets like keys.openAi it would be strictly through repo secrets, meaning if ever they had to update their API they'd need to update the secret in every repo.

If that is the case, what's the purpose in having properties like keys.openAi in the bot config at all if they are just being pulled from the repo meaning that the kernel won't have access to it just the invoked plugin that requires OPENAI_KEY as a secret.

Maybe I've missed a step in the direction V2 is taking and I need to read over some issues again but I'm a little confused with this

gentlementlegen commented 5 months ago

I am not sure to understand the issue. Each repo should have their own secrets, otherwise we also share secrets on an Org level for things like OPENAI_KEY since it's the same for each repo (only orgs can benefit from these shared secrets).

Problem passing down these through the config or the settings is that it can be vector for abuse by third parties which we want to avoid.

gentlementlegen commented 4 months ago

@Keyrxng something going on here or shall I have a look at it?

Keyrxng commented 4 months ago

No issue I can move on this, ty for the follow up.

EDIT:

It can be done, my setup was wrong. Working on things atm

ubiquibot[bot] commented 3 months ago

@Keyrxng the deadline is at 2024-07-25T19:45:57.864Z

ubiquity-os-beta[bot] commented 2 weeks ago

[ 0.028 WXDAI ]
@bytegun

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	0.028

Conversation Incentives

Comment	Formatting	Relevance	Reward
Can I work on this issue?	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	0.2	0.028

[ 2.5345 WXDAI ]
@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	4	2.5345
Review	Comment	34	0

Conversation Incentives

Comment	Formatting	Relevance	Reward
I've already done about 80% of the legwork for this.The troubl…	4.15 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 80 wordValue: 0.1 result: 4.15	0.9	0.93625
@jordan-ae thanks buddy I appreciate itThe repo is private as …	1.49 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 24 wordValue: 0.1 result: 1.49	0.7	0.25825
That would imply that in order to use secrets like `keys.ope…	5.52 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 112 wordValue: 0.1 result: 5.52	0.8	1.104
No issue I can move on this, ty for the follow up.EDIT:It ca…	1.54 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 25 wordValue: 0.1 result: 1.54	0.6	0.236
Resolves https://github.com/ubiquibot/plugins-wishlist/issues/8…	4 content: content: p: score: 0 elementCount: 8 ul: score: 1 elementCount: 1 li: score: 0.5 elementCount: 6 hr: score: 0 elementCount: 1 result: 4 regex: wordCount: 112 wordValue: 0 result: 0	0.9	0
sorry @gentlementlegen do you mean `disable: true` or &#…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0 result: 0	0.6	0
it gets added automatically if you have the latest version of ya…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 58 wordValue: 0 result: 0	0.5	0
Afaik it will always have a sender it's just how the github type…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 58 wordValue: 0 result: 0	0.7	0
![image](https://github.com/user-attachments/assets/65ba06fa-e30…	5 content: content: p: score: 0 elementCount: 2 img: score: 5 elementCount: 1 result: 5 regex: wordCount: 28 wordValue: 0 result: 0	0.8	0
turns out it's corepack (which can be disabled ofc) not yarn but…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 29 wordValue: 0 result: 0	0.7	0
Previously `T` extended all eventNames and was defaulted…	0 content: content: p: score: 0 elementCount: 2 hr: score: 0 elementCount: 1 result: 0 regex: wordCount: 68 wordValue: 0 result: 0	0.8	0
I guess all logs are exposed to the user so that could be an ide…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 20 wordValue: 0 result: 0	0.4	0
perhaps handle those that need it as one separate task then	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 11 wordValue: 0 result: 0	0.4	0
Well yeah the specifics like "test-repo" are for tests only but …	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 54 wordValue: 0 result: 0	0.5	0
I felt like this was a typeguard against `undefined` so …	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 36 wordValue: 0 result: 0	0.6	0
Below does not resolve TS warnings because where `returnOpti…	0 content: content: p: score: 0 elementCount: 11 hr: score: 0 elementCount: 3 result: 0 regex: wordCount: 378 wordValue: 0 result: 0	0.7	0
Exactly yeah it's called 9 times throughout this codebase alone…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 45 wordValue: 0 result: 0	0.6	0
I see what you are saying. Other than not wasting 100s of our ra…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 62 wordValue: 0 result: 0	0.7	0
https://github.com/ubiquity-os-marketplace/daemon-pricing/blob/c…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 57 wordValue: 0 result: 0	0.5	0
So should I leave all references alone in this PR and another PR…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 81 wordValue: 0 result: 0	0.6	0
I actually commented these out just so it wouldn't commit types …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 27 wordValue: 0 result: 0	0.5	0
![image](https://github.com/user-attachments/assets/eff11022-021…	5 content: content: p: score: 0 elementCount: 2 img: score: 5 elementCount: 1 result: 5 regex: wordCount: 4 wordValue: 0 result: 0	0.4	0
@gentlementlegen rfc? I'm about 98% sure it should be	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 10 wordValue: 0 result: 0	0.6	0
QA: https://github.com/ubq-testing/assistive-pricing/actions/run…	27 content: content: p: score: 0 elementCount: 17 img: score: 5 elementCount: 5 hr: score: 0 elementCount: 1 ol: score: 1 elementCount: 1 li: score: 0.5 elementCount: 2 result: 27 regex: wordCount: 137 wordValue: 0 result: 0	0.8	0
Can it be addressed in another task because it'll take some time…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 67 wordValue: 0 result: 0	0.6	0
You want to split this like `telegram-bridge` then and h…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 61 wordValue: 0 result: 0	0.5	0
@gentlementlegen when you installed `@ubiquity-os/ubiquity-o…	15 content: content: p: score: 0 elementCount: 6 img: score: 5 elementCount: 1 a: score: 5 elementCount: 2 result: 15 regex: wordCount: 149 wordValue: 0 result: 0	0.4	0
I'll need to open a new PR in the kernel to move this forward be…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 123 wordValue: 0 result: 0	0.5	0
I've spent the last few hours trying to find a focused solution …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 31 wordValue: 0 result: 0	0.4	0
https://www.npmjs.com/package/@keyrxng/ubiquity-os-kernel - that…	3 content: content: p: score: 0 elementCount: 6 ul: score: 1 elementCount: 1 li: score: 0.5 elementCount: 4 hr: score: 0 elementCount: 1 result: 3 regex: wordCount: 125 wordValue: 0 result: 0	0.4	0
@gentlementlegen I spent another hour or so with the above but n…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 59 wordValue: 0 result: 0	0.5	0
No worries I'll push this on later today	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 9 wordValue: 0 result: 0	0.5	0
yeah sure! actually going this time lmao, I'll let you know and …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 22 wordValue: 0 result: 0	0.4	0
Is this maybe why `kernel-telegram` is not doing anythin…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 34 wordValue: 0 result: 0	0.5	0
https://github.com/ubiquity-os-marketplace/ubiquity-os-kernel-te…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 79 wordValue: 0 result: 0	0.7	0
@gentlementlegen I just merged your changes to save time, tests …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0 result: 0	0.5	0
What do you mean sorry?https://github.com/ubiquity-os-marketpl…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 52 wordValue: 0 result: 0	0.4	0
@gentlementlegen good to go	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0 result: 0	0.5	0

[ 0.2245 WXDAI ]
@jordan-ae

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	0.2245

Conversation Incentives

Comment	Formatting	Relevance	Reward
@Keyrxng Since you've done much of the work already I'll leave i…	1.11 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 17 wordValue: 0.1 result: 1.11	0.8	0.2245

[ 11.411 WXDAI ]
@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	1.48
Review	Comment	21	9.931

Conversation Incentives

Comment	Formatting	Relevance	Reward
We can consider making the org config public, although to me it …	1.85 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 31 wordValue: 0.1 result: 1.85	0.8	1.48
Why add this	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	0.2	0.05
Isn't this casting undefined as string? Seems wrong.	0.65 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 9 wordValue: 0.1 result: 0.65	0.8	0.52
Same	0.1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 1 wordValue: 0.1 result: 0.1	0.7	0.07
Can you elaborate on this comment?	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	0.6	0.276
Perhaps these can be organized in an object called `strings&…	1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1	0.9	0.9
Maybe change your system yarn to v1 because I don't have this pr…	0.94 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94	0.5	0.47
```typescriptconst sender = payload.sender?.login …	1.44 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 23 wordValue: 0.1 result: 1.44	0.8	1.152
I think that might be more appropriate for user facing code. As …	1.28 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 20 wordValue: 0.1 result: 1.28	0.4	0.512
Seems like a hack but I don't understand the types implementatio…	1.85 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 31 wordValue: 0.1 result: 1.85	0.5	0.925
I am not great with type definitions, but seems like you did you…	0.94 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94	0.3	0.282
We should definitely throw an error.	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	0.9	0.414
Code should be cleaned up	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.4	0.156
Ubiquibot term is deprecated Maybe just delete	0.52 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 7 wordValue: 0.1 result: 0.52	0.4	0.208
Let's delete we deprecated the term UbiquiBot officially a coupl…	0.88 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 13 wordValue: 0.1 result: 0.88	0.4	0.352
Doesn't the rest halt execution if any fail in the chain of requ…	1.44 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 23 wordValue: 0.1 result: 1.44	0.7	1.008
We changed these to .ubiquity-os.config.yml. We also need to con…	1.65 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 27 wordValue: 0.1 result: 1.65	0.6	0.99
It's a good idea	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.5	0.195
Well, now we have two. We have development and production instan…	0.94 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94	0.8	0.752
Shouldnt this be enabled	0.32 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0.1 result: 0.32	0.6	0.192
I already have a solution in the works for ~3 second typescript …	1.95 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 33 wordValue: 0.1 result: 1.95	0.2	0.39
Where is the QA test?	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.3	0.117

[ 49.033 WXDAI ]
@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	21.3
Issue	Comment	2	3.118
Review	Comment	34	24.615

Conversation Incentives

Comment	Formatting	Relevance	Reward
A plugin that will update all the price labels if a base rate ch…	7.1 content: content: p: score: 0 elementCount: 2 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 36 wordValue: 0.1 result: 2.1	1	21.3
I am not sure to understand the issue. Each repo should have the…	3.7 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 70 wordValue: 0.1 result: 3.7	0.7	2.59
@Keyrxng something going on here or shall I have a look at it?	0.88 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 13 wordValue: 0.1 result: 0.88	0.6	0.528
Fine with the changes once comments are removed.	0.59 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 8 wordValue: 0.1 result: 0.59	0.3	0.177
Would be better to have it disable if not present in the config …	1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1	0.7	0.7
I remember we had that talk before, but is the sha needed?	0.83 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 12 wordValue: 0.1 result: 0.83	0.5	0.415
just having `globalConfigUpdate` present would imply tha…	1.7 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 28 wordValue: 0.1 result: 1.7	0.8	1.36
Might be overkill but tools like `i18n` could be userful…	0.77 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 11 wordValue: 0.1 result: 0.77	0.4	0.308
I do not know if these strings are exposed to the user. I just t…	3.34 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 62 wordValue: 0.1 result: 3.34	0.2	0.668
It's one of the few plugins that are very verbose with `conv…	1.17 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 18 wordValue: 0.1 result: 1.17	0.3	0.351
This being said, these strings are only used for testing right? …	2.54 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 45 wordValue: 0.1 result: 2.54	0.6	1.524
I'd say it is a bit strange to throw on `undefined`, I w…	2.45 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 43 wordValue: 0.1 result: 2.45	0.6	1.47
This seems a bit dangerous and error prone if we change the name…	2.45 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 43 wordValue: 0.1 result: 2.45	0.7	1.715
Doesn't this run on an Action? I am not sure what is more costly…	2.05 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 35 wordValue: 0.1 result: 2.05	0.6	1.23
Do we want a default here, shouldn't we display an error and sto…	1.06 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06	0.4	0.424
Ha yes I remember this part now. It can be safely ignored then.	0.88 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 13 wordValue: 0.1 result: 0.88	0.2	0.176
I wonder if these constants should be exported from the Kernel t…	0.94 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94	0.5	0.47
https://github.com/ubiquity-os/ubiquity-os-kernel/pull/144	0.71 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 10 wordValue: 0.1 result: 0.71	0.4	0.284
Shall be fixed by using the SDK, can come in a later PR I guess.	1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1	0.5	0.5
You can delete as it is all handled by the SDK.	0.77 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 11 wordValue: 0.1 result: 0.77	0.4	0.308
Should be removed.	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	0.3	0.075
Is this needed now?	0.32 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0.1 result: 0.32	0.2	0.064
It is probably needed but no in the compute file, so can be remo…	1.06 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06	0.3	0.318
Should be handled by the SDK: https://github.com/ubiquity-os-mar…	1.06 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06	0.5	0.53
@Keyrxng Can you please resolve the conflicts?	0.52 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 7 wordValue: 0.1 result: 0.52	0.1	0.052
@Keyrxng I tested in my org and it seems to work fine, I have a …	6.45 content: content: p: score: 0 elementCount: 3 ul: score: 1 elementCount: 1 li: score: 0.5 elementCount: 2 result: 2 regex: wordCount: 87 wordValue: 0.1 result: 4.45	0.6	4.67
Sure thing.What about the commands and the change of labels th…	1.06 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06	0.3	0.318
If it is no deal breaker that `/allow` and label changes…	1.59 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 26 wordValue: 0.1 result: 1.59	0.2	0.318
@Keyrxng Can you resolve the conflicts thank you.	0.59 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 8 wordValue: 0.1 result: 0.59	0.1	0.059
@Keyrxng I made an ESM change to the package today, try it out a…	1.75 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 29 wordValue: 0.1 result: 1.75	0.3	0.525
@Keyrxng As you suggested maybe just split these variables insid…	1.33 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 21 wordValue: 0.1 result: 1.33	0.4	0.532
@Keyrxng I'll have a look, if I can't solve it yes that would be…	1.11 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 17 wordValue: 0.1 result: 1.11	0.4	0.444
@Keyrxng Can you change the `update-configuration.yml` t…	2.3 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 40 wordValue: 0.1 result: 2.3	0.5	1.15
You will also need to add `signature` to `compute.ym…	0.52 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 7 wordValue: 0.1 result: 0.52	0.4	0.208
Plugin works fine for me:https://github.com/Meniole/assistive-…	1.44 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 23 wordValue: 0.1 result: 1.44	0.5	0.72
@Keyrxng problem was that first the `ubiquity logger` wa…	3.7 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 70 wordValue: 0.1 result: 3.7	0.6	2.22
@Keyrxng QA is good, please fix conflicts and let's merge this.	0.83 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 12 wordValue: 0.1 result: 0.83	0.4	0.332

[ 1.728 WXDAI ]
@whilefoo

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	12	1.728

Conversation Incentives

Comment	Formatting	Relevance	Reward
```suggestion```	0 content: content: {} result: 0 regex: wordCount: 0 wordValue: 0.1 result: 0	0.2	0
```suggestionexport async function isConfigModifie…	0 content: content: {} result: 0 regex: wordCount: 0 wordValue: 0.1 result: 0	0.9	0
should throw error	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	0.8	0.0475
should throw error	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	0.8	0.0475
it's better to check if action is in payload rather than assume …	1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1	0.7	0.175
should throw error	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	0.8	0.0475
I've never seen this style in JS, it feels like Rust and I don't…	2.15 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 37 wordValue: 0.1 result: 2.15	0.4	0.2175
should throw error	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	0.6	0.035
try to avoid casts if possible	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	0.5	0.0625
I'm not against throwing if a value is undefined (where it makes…	3.7 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 70 wordValue: 0.1 result: 3.7	0.6	0.56
we should enable this since it's used for authentication, otherw…	1.33 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 21 wordValue: 0.1 result: 1.33	0.9	0.29675
I've tried with kernel v2.2.0 and it works but when I tried v2.3…	3.15 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 58 wordValue: 0.1 result: 3.15	0.3	0.23875

ubiquity-os-beta[bot] commented 2 weeks ago

@gentlementlegen the deadline is at Mon, Oct 28, 9:04 PM UTC

ubiquity-os-beta[bot] commented 2 weeks ago

@Keyrxng the deadline is at Mon, Oct 28, 9:04 PM UTC

gentlementlegen commented 2 weeks ago

@Keyrxng My mistake sorry.

ubiquity-os-beta[bot] commented 2 weeks ago

[ 300 WXDAI ]
@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	300
Issue	Comment	4	0
Review	Comment	34	0

Conversation Incentives

Comment	Formatting	Relevance
I've already done about 80% of the legwork for this.The troubl…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 80 wordValue: 0 result: 0	0.85
@jordan-ae thanks buddy I appreciate itThe repo is private as …	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 24 wordValue: 0 result: 0	0.75
That would imply that in order to use secrets like `keys.ope…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 112 wordValue: 0 result: 0	0.65
No issue I can move on this, ty for the follow up.EDIT:It ca…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 25 wordValue: 0 result: 0	0.8
Resolves https://github.com/ubiquibot/plugins-wishlist/issues/8…	4 content: content: p: score: 0 elementCount: 8 ul: score: 1 elementCount: 1 li: score: 0.5 elementCount: 6 hr: score: 0 elementCount: 1 result: 4 regex: wordCount: 112 wordValue: 0 result: 0	0.9
sorry @gentlementlegen do you mean `disable: true` or &#…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0 result: 0	0.5
it gets added automatically if you have the latest version of ya…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 58 wordValue: 0 result: 0	0.7
Afaik it will always have a sender it's just how the github type…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 58 wordValue: 0 result: 0	0.6
![image](https://github.com/user-attachments/assets/65ba06fa-e30…	5 content: content: p: score: 0 elementCount: 2 img: score: 5 elementCount: 1 result: 5 regex: wordCount: 28 wordValue: 0 result: 0	0.6
turns out it's corepack (which can be disabled ofc) not yarn but…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 29 wordValue: 0 result: 0	0.6
Previously `T` extended all eventNames and was defaulted…	0 content: content: p: score: 0 elementCount: 2 hr: score: 0 elementCount: 1 result: 0 regex: wordCount: 68 wordValue: 0 result: 0	0.7
I guess all logs are exposed to the user so that could be an ide…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 20 wordValue: 0 result: 0	0.4
perhaps handle those that need it as one separate task then	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 11 wordValue: 0 result: 0	0.3
Well yeah the specifics like "test-repo" are for tests only but …	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 54 wordValue: 0 result: 0	0.3
I felt like this was a typeguard against `undefined` so …	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 36 wordValue: 0 result: 0	0.8
Below does not resolve TS warnings because where `returnOpti…	0 content: content: p: score: 0 elementCount: 11 hr: score: 0 elementCount: 3 result: 0 regex: wordCount: 378 wordValue: 0 result: 0	0.8
Exactly yeah it's called 9 times throughout this codebase alone…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 45 wordValue: 0 result: 0	0.6
I see what you are saying. Other than not wasting 100s of our ra…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 62 wordValue: 0 result: 0	0.5
https://github.com/ubiquity-os-marketplace/daemon-pricing/blob/c…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 57 wordValue: 0 result: 0	0.5
So should I leave all references alone in this PR and another PR…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 81 wordValue: 0 result: 0	0.4
I actually commented these out just so it wouldn't commit types …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 27 wordValue: 0 result: 0	0.3
![image](https://github.com/user-attachments/assets/eff11022-021…	5 content: content: p: score: 0 elementCount: 2 img: score: 5 elementCount: 1 result: 5 regex: wordCount: 4 wordValue: 0 result: 0	0.2
@gentlementlegen rfc? I'm about 98% sure it should be	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 10 wordValue: 0 result: 0	0.6
QA: https://github.com/ubq-testing/assistive-pricing/actions/run…	27 content: content: p: score: 0 elementCount: 17 img: score: 5 elementCount: 5 hr: score: 0 elementCount: 1 ol: score: 1 elementCount: 1 li: score: 0.5 elementCount: 2 result: 27 regex: wordCount: 137 wordValue: 0 result: 0	0.9
Can it be addressed in another task because it'll take some time…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 67 wordValue: 0 result: 0	0.4
You want to split this like `telegram-bridge` then and h…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 61 wordValue: 0 result: 0	0.4
@gentlementlegen when you installed `@ubiquity-os/ubiquity-o…	15 content: content: p: score: 0 elementCount: 6 img: score: 5 elementCount: 1 a: score: 5 elementCount: 2 result: 15 regex: wordCount: 149 wordValue: 0 result: 0	0.7
I'll need to open a new PR in the kernel to move this forward be…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 123 wordValue: 0 result: 0	0.6
I've spent the last few hours trying to find a focused solution …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 31 wordValue: 0 result: 0	0.5
https://www.npmjs.com/package/@keyrxng/ubiquity-os-kernel - that…	3 content: content: p: score: 0 elementCount: 6 ul: score: 1 elementCount: 1 li: score: 0.5 elementCount: 4 hr: score: 0 elementCount: 1 result: 3 regex: wordCount: 125 wordValue: 0 result: 0	0.4
@gentlementlegen I spent another hour or so with the above but n…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 59 wordValue: 0 result: 0	0.5
No worries I'll push this on later today	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 9 wordValue: 0 result: 0	0.2
yeah sure! actually going this time lmao, I'll let you know and …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 22 wordValue: 0 result: 0	0.3
Is this maybe why `kernel-telegram` is not doing anythin…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 34 wordValue: 0 result: 0	0.4
https://github.com/ubiquity-os-marketplace/ubiquity-os-kernel-te…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 79 wordValue: 0 result: 0	0.6
@gentlementlegen I just merged your changes to save time, tests …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0 result: 0	0.5
What do you mean sorry?https://github.com/ubiquity-os-marketpl…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 52 wordValue: 0 result: 0	0.3
@gentlementlegen good to go	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0 result: 0	0.4

[ 0.03375 WXDAI ]
@bytegun

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	0.03375

Conversation Incentives

Comment	Formatting	Relevance	Reward
Can I work on this issue?	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	0.25	0.03375

[ 0.19675 WXDAI ]
@jordan-ae

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	0.19675

Conversation Incentives

Comment	Formatting	Relevance	Reward
@Keyrxng Since you've done much of the work already I'll leave i…	1.11 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 17 wordValue: 0.1 result: 1.11	0.7	0.19675

[ 11.2455 WXDAI ]
@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	1.3875
Review	Comment	21	9.858

Conversation Incentives

Comment	Formatting	Relevance	Reward
We can consider making the org config public, although to me it …	1.85 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 31 wordValue: 0.1 result: 1.85	0.75	1.3875
Why add this	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	0.3	0.075
Isn't this casting undefined as string? Seems wrong.	0.65 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 9 wordValue: 0.1 result: 0.65	0.7	0.455
Same	0.1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 1 wordValue: 0.1 result: 0.1	0.6	0.06
Can you elaborate on this comment?	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	0.5	0.23
Perhaps these can be organized in an object called `strings&…	1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1	0.8	0.8
Maybe change your system yarn to v1 because I don't have this pr…	0.94 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94	0.4	0.376
```typescriptconst sender = payload.sender?.login …	1.44 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 23 wordValue: 0.1 result: 1.44	0.9	1.296
I think that might be more appropriate for user facing code. As …	1.28 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 20 wordValue: 0.1 result: 1.28	0.5	0.64
Seems like a hack but I don't understand the types implementatio…	1.85 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 31 wordValue: 0.1 result: 1.85	0.4	0.74
I am not great with type definitions, but seems like you did you…	0.94 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94	0.3	0.282
We should definitely throw an error.	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	0.8	0.368
Code should be cleaned up	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.1	0.039
Ubiquibot term is deprecated Maybe just delete	0.52 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 7 wordValue: 0.1 result: 0.52	0.7	0.364
Let's delete we deprecated the term UbiquiBot officially a coupl…	0.88 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 13 wordValue: 0.1 result: 0.88	0.7	0.616
Doesn't the rest halt execution if any fail in the chain of requ…	1.44 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 23 wordValue: 0.1 result: 1.44	0.9	1.296
We changed these to .ubiquity-os.config.yml. We also need to con…	1.65 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 27 wordValue: 0.1 result: 1.65	0.6	0.99
It's a good idea	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.5	0.195
Well, now we have two. We have development and production instan…	0.94 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94	0.4	0.376
Shouldnt this be enabled	0.32 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0.1 result: 0.32	0.6	0.192
I already have a solution in the works for ~3 second typescript …	1.95 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 33 wordValue: 0.1 result: 1.95	0.2	0.39
Where is the QA test?	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.2	0.078

[ 56.423 WXDAI ]
@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	21.3
Issue	Comment	3	3.552
Review	Comment	34	31.571

Conversation Incentives

Comment	Formatting	Relevance	Reward
A plugin that will update all the price labels if a base rate ch…	7.1 content: content: p: score: 0 elementCount: 2 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 36 wordValue: 0.1 result: 2.1	1	21.3
I am not sure to understand the issue. Each repo should have the…	3.7 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 70 wordValue: 0.1 result: 3.7	0.8	2.96
@Keyrxng something going on here or shall I have a look at it?	0.88 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 13 wordValue: 0.1 result: 0.88	0.6	0.528
@Keyrxng My mistake sorry.	0.32 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0.1 result: 0.32	0.2	0.064
Fine with the changes once comments are removed.	0.59 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 8 wordValue: 0.1 result: 0.59	0.5	0.295
Would be better to have it disable if not present in the config …	1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1	0.7	0.7
I remember we had that talk before, but is the sha needed?	0.83 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 12 wordValue: 0.1 result: 0.83	0.5	0.415
just having `globalConfigUpdate` present would imply tha…	1.7 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 28 wordValue: 0.1 result: 1.7	0.9	1.53
Might be overkill but tools like `i18n` could be userful…	0.77 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 11 wordValue: 0.1 result: 0.77	0.4	0.308
I do not know if these strings are exposed to the user. I just t…	3.34 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 62 wordValue: 0.1 result: 3.34	0.6	2.004
It's one of the few plugins that are very verbose with `conv…	1.17 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 18 wordValue: 0.1 result: 1.17	0.3	0.351
This being said, these strings are only used for testing right? …	2.54 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 45 wordValue: 0.1 result: 2.54	0.7	1.778
I'd say it is a bit strange to throw on `undefined`, I w…	2.45 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 43 wordValue: 0.1 result: 2.45	0.8	1.96
This seems a bit dangerous and error prone if we change the name…	2.45 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 43 wordValue: 0.1 result: 2.45	1	2.45
Doesn't this run on an Action? I am not sure what is more costly…	2.05 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 35 wordValue: 0.1 result: 2.05	0.4	0.82
Do we want a default here, shouldn't we display an error and sto…	1.06 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06	0.9	0.954
Ha yes I remember this part now. It can be safely ignored then.	0.88 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 13 wordValue: 0.1 result: 0.88	0.2	0.176
I wonder if these constants should be exported from the Kernel t…	0.94 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94	0.6	0.564
https://github.com/ubiquity-os/ubiquity-os-kernel/pull/144	0.71 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 10 wordValue: 0.1 result: 0.71	0.2	0.142
Shall be fixed by using the SDK, can come in a later PR I guess.	1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1	0.5	0.5
You can delete as it is all handled by the SDK.	0.77 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 11 wordValue: 0.1 result: 0.77	0.4	0.308
Should be removed.	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	0.8	0.2
Is this needed now?	0.32 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0.1 result: 0.32	0.3	0.096
It is probably needed but no in the compute file, so can be remo…	1.06 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06	0.4	0.424
Should be handled by the SDK: https://github.com/ubiquity-os-mar…	1.06 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06	0.7	0.742
@Keyrxng Can you please resolve the conflicts?	0.52 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 7 wordValue: 0.1 result: 0.52	0.4	0.208
@Keyrxng I tested in my org and it seems to work fine, I have a …	6.45 content: content: p: score: 0 elementCount: 3 ul: score: 1 elementCount: 1 li: score: 0.5 elementCount: 2 result: 2 regex: wordCount: 87 wordValue: 0.1 result: 4.45	0.6	4.67
Sure thing.What about the commands and the change of labels th…	1.06 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06	0.5	0.53
If it is no deal breaker that `/allow` and label changes…	1.59 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 26 wordValue: 0.1 result: 1.59	0.3	0.477
@Keyrxng Can you resolve the conflicts thank you.	0.59 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 8 wordValue: 0.1 result: 0.59	0.5	0.295
@Keyrxng I made an ESM change to the package today, try it out a…	1.75 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 29 wordValue: 0.1 result: 1.75	0.6	1.05
@Keyrxng As you suggested maybe just split these variables insid…	1.33 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 21 wordValue: 0.1 result: 1.33	0.6	0.798
@Keyrxng I'll have a look, if I can't solve it yes that would be…	1.11 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 17 wordValue: 0.1 result: 1.11	0.5	0.555
@Keyrxng Can you change the `update-configuration.yml` t…	2.3 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 40 wordValue: 0.1 result: 2.3	0.6	1.38
You will also need to add `signature` to `compute.ym…	0.52 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 7 wordValue: 0.1 result: 0.52	0.7	0.364
Plugin works fine for me:https://github.com/Meniole/assistive-…	1.44 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 23 wordValue: 0.1 result: 1.44	0.8	1.152
@Keyrxng problem was that first the `ubiquity logger` wa…	3.7 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 70 wordValue: 0.1 result: 3.7	0.8	2.96
@Keyrxng QA is good, please fix conflicts and let's merge this.	0.83 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 12 wordValue: 0.1 result: 0.83	0.5	0.415

[ 2.192625 WXDAI ]
@whilefoo

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	12	2.192625

Conversation Incentives

Comment	Formatting	Relevance	Reward
```suggestion```	0 content: content: {} result: 0 regex: wordCount: 0 wordValue: 0.1 result: 0	0.1	0
```suggestionexport async function isConfigModifie…	0 content: content: {} result: 0 regex: wordCount: 0 wordValue: 0.1 result: 0	0.8	0
should throw error	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	0.9	0.05375
should throw error	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	0.9	0.05375
it's better to check if action is in payload rather than assume …	1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1	0.85	0.2125
should throw error	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	0.9	0.05375
I've never seen this style in JS, it feels like Rust and I don't…	2.15 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 37 wordValue: 0.1 result: 2.15	0.5	0.27125
should throw error	0.25 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 3 wordValue: 0.1 result: 0.25	0.9	0.05375
try to avoid casts if possible	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	0.7	0.0855
I'm not against throwing if a value is undefined (where it makes…	3.7 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 70 wordValue: 0.1 result: 3.7	0.75	0.69875
we should enable this since it's used for authentication, otherw…	1.33 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 21 wordValue: 0.1 result: 1.33	0.95	0.313375
I've tried with kernel v2.2.0 and it works but when I tried v2.3…	3.15 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 58 wordValue: 0.1 result: 3.15	0.5	0.39625

Keyrxng commented 2 weeks ago

@gentlementlegen no worries. I suggested we build a feature so that it auto assigns the author of the pr being merged before we generate the permit it would be so beneficial to avoid this as it happens often

gentlementlegen commented 2 weeks ago

Should be good when we get the disqualifier to work and actually disqualify people, because it will close PRs as well, and the user won't be able to re-assign itself.

Deadline	Mon, May 20, 1:14 PM UTC
Registered Wallet	0x2F05fD58023B0a95d1866aa0A3b672cEf05945c5

ubiquity-os / plugins-wishlist