Feat/proxy callbacks - Githubissues

ubiquity-os / ubiquity-os-kernel

1 stars 19 forks source link

Feat/proxy callbacks #191

Closed Keyrxng closed 6 days ago

Keyrxng commented 1 week ago

Resolves https://github.com/ubiquity-os/ubiquity-os-kernel/issues/190

adds CallbackBuilder class to help build the proxyCallbacks object
createPlugin takes CallbackBuilder instead of handler()
wrote a post-build script to clean and build a package.json for each dir we end up having
/sdk and /types right now but easy to add others

QA: https://github.com/ubq-testing/qa-plugin/issues/1

Building callbacks:

Callback signature:

Clean package.json per dist dir:

Keyrxng commented 1 week ago

@gentlementlegen @whilefoo Fancy a peak?

Still to accommodate actions, fix failing tests and will do that tmrw but it's a matter of replicating the code pretty much (will try to avoid actually copy/pasting).

Anything sticking out so far that's a deal breaker?

Also am I correct in thinking the package.json in this repo is configured for the kernel, not specifically the SDK of the kernel?

Keyrxng commented 1 week ago

Keyrxng commented 6 days ago

Makes sense to PR the SDK so I'll need to redo this PR

Keyrxng commented 6 days ago

https://github.com/ubiquity-os-marketplace/command-ask/issues/26#issuecomment-2466693490

If this PR is a priority can the task be priced and I'll be happy to re-do things (once the location of where the SDK will live is decided)