search

ubiquity-os / ubiquity-os-kernel

1 stars 19 forks source link

fix: remove SDK files and update dependencies #193

Closed gentlementlegen closed 6 days ago

gentlementlegen commented 1 week ago

Deleted src/sdk directory, adjusted dependencies, and updated relevant imports. The new SDK is located at https://github.com/ubiquity-os/plugin-sdk

Resolves #192

@whilefoo I wonder if it makes sense to move the signature within the SDK as well. The problem now is that the signature gets created inside the kernel and decoded within the SDK which is prone to error. Related PR: https://github.com/ubiquity-os/plugin-sdk/pull/22

whilefoo commented 1 week ago

@whilefoo I wonder if it makes sense to move the signature within the SDK as well. The problem now is that the signature gets created inside the kernel and decoded within the SDK which is prone to error. Related PR: ubiquity-os/plugin-sdk#22

I'm not sure what you mean by that. Do you mean to move signature creation/verification functions inside the SDK and import them from SDK in the kernel?

gentlementlegen commented 1 week ago

@whilefoo Yes exactly, this way the encode / decode happens in the same package which seems to make more sense to me.

whilefoo commented 1 week ago

Yeah it makes sense because when you modify encode, you also need to modify decode so if it was separate you would need to update both packages

gentlementlegen commented 1 week ago

Yeah it makes sense because when you modify encode, you also need to modify decode so if it was separate you would need to update both packages

Indeed. Then I will move the encode logic as well and include the package here.

gentlementlegen commented 6 days ago

@whilefoo moved this in a signature import within the SDK: https://github.com/ubiquity-os/ubiquity-os-kernel/pull/193/files#diff-9d1e92d5ff6f0b749097b71ca93f176a78310fe4c8da4d615811d4c128df2050R7