ubiquity-os / ubiquity-os-kernel

1 stars 19 forks source link

chore: added CLOUDFLARE_ACCOUNT_ID to env setup-kv build step #63

Closed gentlementlegen closed 4 months ago

gentlementlegen commented 4 months ago

Resolves #62

gentlementlegen commented 4 months ago

I tried to have a CloudFlare account with multiple accounts to replicate this issue.

Before adding the environment variable: https://github.com/Meniole/ubiquibot-kernel/actions/runs/9599522524/job/26473556857

After adding CLOUDFLARE_ACCOUNT_ID: https://github.com/Meniole/ubiquibot-kernel/actions/runs/9599656720/job/26474110307

So adding the variable properly helps wrangler use the right account. I do not have access to the settings on this repository, if someone could set that value. It has to match the account that is used to deploy the current workers (should be this one?).

0x4007 commented 4 months ago

to the settings on this repository

Or should we place in org secrets? All of our secrets are basically in org secrets.

Also as a heads up for the @ubiquity organization, @rndquu is the defacto admin.

Yes I am an admin but I don't want to set expectations that I am always available. We just don't have a lot of pitch calls these days scheduled for the fundraising (working on fixing this.)

gentlementlegen commented 4 months ago

@0x4007 Gotcha. It can go in org secrets, so far we only had use for it in this specific repo. Either shall work.

0x4007 commented 4 months ago
image

We already have it in our org secrets as it turns out @gentlementlegen

gentlementlegen commented 4 months ago

Successful deploy: https://github.com/Meniole/ubiquibot-kernel/actions/runs/9616621427