ubiquity-os / ubiquity-os-kernel

1 stars 19 forks source link

Remove Unnecessary Secrets #69

Closed 0x4007 closed 4 months ago

0x4007 commented 4 months ago

Upon deploy of v2 we had to add several new secrets which were not necessary for v1. This indicates that they are not essential and must be removed.

gentlementlegen commented 4 months ago

/start The WEBHOOK_PROXY_URL is for development only. But the WEBHOOK_SECRET is required to communicate with the GitHub app, if set. Will check if it can be made optional.


WEBHOOK_SECRET is definitely required due to https://github.com/ubiquity/ubiquibot-kernel/blob/afc96262f402f62e6dc611142b9a02c7eac8942c/src/github/github-event-handler.ts#L33 which is not optional.

ubiquibot[bot] commented 4 months ago

DeadlineTue, Jul 9, 12:06 AM UTC
Registered Wallet 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED
Tips:
ubiquibot[bot] commented 4 months ago
+ Evaluating results. Please wait...
ubiquibot[bot] commented 4 months ago

[ 10 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueSpecification110
Conversation Incentives
CommentFormattingRelevanceReward
Upon deploy of v2 we had to add several new secrets which were n...
10
li:
  count: 2
  score: "2"
  words: 6
code:
  count: 2
  score: "2"
  words: 2
110

[ 50 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask150