ubiquity-os / ubiquity-os-kernel

1 stars 13 forks source link

Add a `runs_on` section to the configuration and the manifests #73

Closed gentlementlegen closed 2 months ago

gentlementlegen commented 2 months ago

We will have a runs_on item that will describe which events the plugin will be subscribed to, according to the following discussion.

Expected format:

The configuration takes over the manifest is present, otherwise the manifest is the default.

ubiquibot[bot] commented 2 months ago

@gentlementlegen, You are not allowed to add Time: <4 Hours

ubiquibot[bot] commented 2 months ago
! No permission to set labels
0x4007 commented 2 months ago

runsOn Camel case seems unexpected. What about snake case as I've seen in the manifest standard.

Or better, consider a one word solution like subscribe, invoke, listener (reference to event listener)

Some other interesting syntax:

"plugin:addEventListener": [ ... ]

Also isn't uses: superfluous?

gentlementlegen commented 2 months ago

Let's make it plural as it is a list, I propose subscriptions or listeners then.

Isn't "plugin:addEventListener" camel case as well?

uses is because you can have other properties such as name, id, description that I didn't list in the spec because not relevant, and because it is an array.

gentlementlegen commented 2 months ago

When closed, the following configurations should be updated: https://github.com/ubiquity/ubiquibot-config/blob/development/.github/.ubiquibot-config.ymlhttps://github.com/ubiquibot/ubiquibot-config/blob/main/.github/.ubiquibot-config.yml

ubiquibot[bot] commented 2 months ago
+ Evaluating results. Please wait...
ubiquibot-dev[bot] commented 2 months ago

[ 119.56 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Task 1 100
Issue Specification 1 9.9
Issue Comment 2 9.66
Conversation Incentives
Comment Formatting Relevance Reward
We will have a `runs_on` item that will describe which e…
9.9
content:
  p:
    count: 73
    score: 1
  code:
    count: 26
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 9.9
Let's make it plural as it is a list, I propose `subscriptio…
11.4
content:
  p:
    count: 50
    score: 1
  code:
    count: 7
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.8 9.12
When closed, the following configurations should be updated: htt…
1.8
content:
  p:
    count: 9
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.3 0.54

[ 4.165 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 1 4.165
Conversation Incentives
Comment Formatting Relevance Reward
`runsOn` Camel case seems unexpected. What about snake c…
4.9
content:
  p:
    count: 43
    score: 1
  code:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.85 4.165
ubiquibot[bot] commented 2 months ago

[ 7.7 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment17.3
ReviewComment10.4
Conversation Incentives
CommentFormattingRelevanceReward
`runsOn` Camel case seems unexpected. What about snake c...
7.3
code:
  count: 3
  score: "3"
  words: 6
0.637.3
@gentlementlegen yes merge them....
0.40.080.4

[ 204.9 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueSpecification118.2
IssueTask1100
IssueComment224
IssueComment20
ReviewComment441.8
ReviewComment420.9
Conversation Incentives
CommentFormattingRelevanceReward
We will have a `runs_on` item that will describe which e...
18.2
li:
  count: 2
  score: "2"
  words: 8
code:
  count: 3
  score: "3"
  words: 1
118.2
Let's make it plural as it is a list, I propose `subscriptio...
17.8
code:
  count: 7
  score: "7"
  words: 10
0.7517.8
When closed, the following configurations should be updated: ht...
6.20.556.2
Let's make it plural as it is a list, I propose `subscriptio...
-
code:
  count: 7
  score: "0"
  words: 10
0.75-
When closed, the following configurations should be updated: ht...
-0.55-
For this PR to work properly, all the related manifest pull-requ...
5.40.155.4
> @gentlementlegen Check [this](https://github.com/rndquu-org...
17.6
a:
  count: 3
  score: "6"
  words: 5
code:
  count: 3
  score: "6"
  words: 8
0.6117.6
@rndquu The issue was that the `hello-world` plugin woul...
15
code:
  count: 1
  score: "2"
  words: 2
0.7815
@rndquu Thank you for the remark, created a ticket for it: https...
3.80.613.8
For this PR to work properly, all the related manifest pull-requ...
2.70.152.7
> @gentlementlegen Check [this](https://github.com/rndquu-org...
8.8
a:
  count: 3
  score: "3"
  words: 5
code:
  count: 3
  score: "3"
  words: 8
0.618.8
@rndquu The issue was that the `hello-world` plugin woul...
7.5
code:
  count: 1
  score: "1"
  words: 2
0.787.5
@rndquu Thank you for the remark, created a ticket for it: https...
1.90.611.9

[ 21.1 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
ReviewComment321.1
Conversation Incentives
CommentFormattingRelevanceReward
@gentlementlegen Check [this](https://github.com/rndquu-org/test...
8.5
a:
  count: 3
  score: "3"
  words: 5
code:
  count: 2
  score: "2"
  words: 7
0.38.5
@gentlementlegen Check [this](https://github.com/rndquu-org/test...
8.4
a:
  count: 4
  score: "4"
  words: 5
code:
  count: 1
  score: "1"
  words: 1
0.728.4
> @rndquu The issue was that the `hello-world` plugin...
4.2
code:
  count: 1
  score: "1"
  words: 2
0.654.2
0x4007 commented 2 months ago

@gentlementlegen Review comments aren't taken into account

gentlementlegen commented 2 months ago

@0x4007 Same issue as usual, will also link to https://github.com/ubiquibot/conversation-rewards/issues/26