Closed gentlementlegen closed 3 months ago
@gentlementlegen, You are not allowed to add Time: <2 Hours
! No permission to set labels
such as start stop.
This is half relevant comment, but what if we force each plugin to only support a single command so that they are tightly scoped?
I am conflicted because on one hand I want to make the kernel superior to be able to handle everything. On the other hand, I want to encourage solid plugin development. I don't want to see developers tempted to make one super plugin that has tons of capabilities and is a mess of code etc. More modularity allows partners to more finely customize their configurations for their requirements.
(/stop
technically can be replaced by the assignee self unassigning using the GitHub UI.)
I think in some cases it would lead to a lot of duplicated code, thus lot of duplicated bugs. Maybe start stop is not the best example (plus we talked about assigning without the need to do the /start
command just by linking a pull-request), but probably for complex commands it will be a required feature.
but probably for complex commands it will be a required feature.
Yes but this clearly illustrates that it isn't a priority now right?
Anyways, as long as the changes to the code are not complex, then we can add this capability now. If it is complex, I think its wise to defer until absolutely needed.
It should be a fairly simple change (< 1h, tops 2h with the related tests), and would be required for our current version of start stop
.
+ Evaluating results. Please wait...
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 50 |
Issue | Specification | 1 | 6.5 |
Issue | Comment | 2 | 11.32 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
The Kernel does not forward commands if the configuration does n… | 6.5content: p: count: 60 score: 1 a: count: 5 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 1 | 6.5 |
I think in some cases it would lead to a lot of duplicated code,… | 11.4content: p: count: 56 score: 1 code: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 1 | 0.6 | 6.84 |
It should be a fairly simple change (< 1h, tops 2h with the r… | 5.6content: p: count: 26 score: 1 code: count: 2 score: 1 wordValue: 0.2 formattingMultiplier: 1 | 0.8 | 4.48 |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 2 | 7.74 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
This is half relevant comment, but what if we force each plugin … | 10.7content: p: count: 106 score: 1 code: count: 1 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.6 | 6.42 |
Yes but this clearly illustrates that it isn't a priority now ri… | 4.4content: p: count: 44 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.3 | 1.32 |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 2 | 17.2 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
> such as [start stop](https://github.com/ubiquibot/command-s... | 12.7a: count: 1 score: "1" words: 2 code: count: 1 score: "1" words: 1 | 0.7 | 12.7 |
> but probably for complex commands it will be a required fea... | 4.5 | 0.68 | 4.5 |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 15 |
Issue | Task | 1 | 50 |
Issue | Comment | 2 | 18.4 |
Issue | Comment | 2 | 0 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
The Kernel does not forward commands if the configuration does n... | 15a: count: 3 score: "3" words: 5 | 1 | 15 |
I think in some cases it would lead to a lot of duplicated code,... | 12.4code: count: 1 score: "1" words: 1 | 0.725 | 12.4 |
It should be a fairly simple change (< 1h, tops 2h with the r... | 6code: count: 1 score: "1" words: 2 | 0.9 | 6 |
I think in some cases it would lead to a lot of duplicated code,... | -code: count: 1 score: "0" words: 1 | 0.725 | - |
It should be a fairly simple change (< 1h, tops 2h with the r... | -code: count: 1 score: "0" words: 2 | 0.9 | - |
The Kernel does not forward commands if the configuration does not list the command, as seen in this code. It works usually fine except for plugins that can handle multiple commands, such as start stop.
Once the manifests are up and running, it would be important to update the logic so multiple commands can be handled by the same plugin.