search

ubiquity-os / ubiquity-os-kernel

1 stars 13 forks source link

Skip plugin run on missing manifest.json file #78

Closed gentlementlegen closed 5 days ago

gentlementlegen commented 2 months ago

The kernel should skip plugins that do not serve a manifest as they should be considered invalid. 

          > @rndquu The issue was that the `hello-world` plugin would not serve the manifest, so the kernel would not be able to filter out the commands. I added a manifest and serve it, which should solve the problem. Also I merged in PR #75 within this one because it was needed to properly filter out the commands anyway.

If plugin doesn't serve manifest at all then what's going to happen? Perhaps we should create a new github issue for showing empty manifest related error and stopping plugin execution?

Originally posted by @rndquu in https://github.com/ubiquity/ubiquibot-kernel/issues/74#issuecomment-2247059148

ubiquibot[bot] commented 2 months ago

@gentlementlegen, You are not allowed to add Time: <1 Hour

ubiquibot[bot] commented 2 months ago 
! No permission to set labels
gentlementlegen commented 5 days ago

I think this is covered by https://github.com/ubiquity/ubiquibot-kernel/issues/80 and now when a manifest is not found, no run happens because the manifest should describe which events the plugin will react to.

ubiquity-os[bot] commented 5 days ago 
# Issue was not closed as completed. Skipping.