search

ubiquity-os / ubiquity-os-kernel

1 stars 13 forks source link

`skipBotEvents` set to `false` still seems to skip bot events #98

Closed gentlementlegen closed 2 weeks ago

gentlementlegen commented 1 month ago

Even when set to false the events triggered by a bot do not seem to be dispatched by the kernel, for example after a automated-merging action that should trigger a conversation-rewards by closing the issue but doesn't happen, like here. The proper behavior would be to have to action / worker triggered when this is set to false in the configuration.

Keyrxng commented 1 month ago

Related to https://github.com/ubiquity/ubiquibot-kernel/issues/94 I'm sure

gentlementlegen commented 2 weeks ago

It seems that this works as long as skipBotEvents is placed at the top of the plugins section. Test run here: https://github.com/Meniole/automated-merging/issues/7

ubiquity-os[bot] commented 2 weeks ago 
# Issue was not closed as completed. Skipping.
0x4007 commented 2 weeks ago

I filed a new plugin that might rely on not automatically generating permits from these automated merges as a heads up. Perhaps we shouldn't "fix" this "feature" yet @gentlementlegen

gentlementlegen commented 2 weeks ago

@0x4007 It's not broken so nothing to be fixed, I misunderstood how to use this configuration value if we want to run plugins on bot actions. You can configure it here.