ubiquity-os / ubiquity-os-logger

0 stars 6 forks source link

Compatibility for CommonJs and ESM #19

Closed gentlementlegen closed 4 months ago

gentlementlegen commented 4 months ago

The package is currently only compiled for ESM projects, which implies adding the "type": "module". This usually breaks projects that are using older techs requiring "type": "commonjs", which is broadly used within our organization and the packages we include. It would be better to offer both solutions, as this package doesn't require to be in ESM to work properly.

Tasks to be carried out:

ubiquibot[bot] commented 4 months ago

@gentlementlegen, You are not allowed to add Priority: 1 (Normal)

ubiquibot[bot] commented 4 months ago

@gentlementlegen, You are not allowed to add Time: <1 Hour

ubiquibot[bot] commented 4 months ago
! No permission to set labels
ubiquibot[bot] commented 4 months ago
! No permission to set labels
0x4007 commented 4 months ago

I think setting permissions is broken last time we tried. Can make you billing manager though. Will need to try when back on computer later.

gentlementlegen commented 4 months ago

@0x4007 Well I am billing manager within Ubiquity Org, so the issue might be different. Yes I recall it being broken as well. It's not urgent I guess, just a bit annoying 😄

ubiquibot[bot] commented 4 months ago
! No price label has been set. Skipping permit generation.
ubiquity-os-main[bot] commented 4 months ago
! No price label has been set. Skipping permit generation.
ubiquibot[bot] commented 4 months ago
+ Evaluating results. Please wait...
ubiquity-os-main[bot] commented 4 months ago

[ 0 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Comment 1 0
Conversation Incentives
Comment Formatting Relevance Reward
I think setting permissions is broken last time we tried. Can ma…
2.5
content:
  p:
    count: 25
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -

[ 35.62 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Task 1 25
Issue Specification 1 9.3
Issue Comment 1 1.32
Conversation Incentives
Comment Formatting Relevance Reward
The package is currently only compiled for ESM projects, which i…
9.3
content:
  p:
    count: 87
    score: 1
  code:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 9.3
@0x4007 Well I am billing manager within Ubiquity Org, so the is…
6.6
content:
  p:
    count: 33
    score: 1
wordValue: 0.2
formattingMultiplier: 1
0.2 1.32
ubiquibot[bot] commented 4 months ago

[ 2.5 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment12.5
Conversation Incentives
CommentFormattingRelevanceReward
I think setting permissions is broken last time we tried. Can ma...
2.50.172.5

[ 106 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueSpecification124
IssueTask125
IssueComment16.6
IssueComment10
ReviewComment133.6
ReviewComment116.8
Conversation Incentives
CommentFormattingRelevanceReward
The package is currently only compiled for ESM projects, which i...
24
li:
  count: 3
  score: "3"
  words: 24
code:
  count: 4
  score: "4"
  words: 14
124
@0x4007 Well I am billing manager within Ubiquity Org, so the is...
6.60.36.6
@0x4007 Well I am billing manager within Ubiquity Org, so the is...
-0.3-
## How to test Create a dummy NodeJs project, with the followin...
33.6
h2:
  count: 1
  score: "2"
  words: 3
code:
  count: 7
  score: "14"
  words: 22
0.9333.6
## How to test Create a dummy NodeJs project, with the followin...
16.8
h2:
  count: 1
  score: "1"
  words: 3
code:
  count: 7
  score: "7"
  words: 22
0.9316.8
0x4007 commented 4 months ago

Why is my comment relevance 0 on v2? I expect it to be low but not 0

gentlementlegen commented 4 months ago

@0x4007 miggt be due to either Gpt4 or a multiplier that makes it 0, will have a look

0x4007 commented 4 months ago

Relevance made it 0 but ChatGPT I wouldn't expect to return a perfect 0

gentlementlegen commented 4 months ago

I think I defaulted to 0 if there is any bug or crash during the evaluation of relevance to avoid major issues on the final result, which might be the reason.

0x4007 commented 4 months ago

In my implementation I made it default to 1 in case of error. Seems unfair to the contributor to not get any credit if there's a bug with the software.

gentlementlegen commented 4 months ago

Added this to the specification.