ubiquity-os / ubiquity-os-logger

0 stars 6 forks source link

feat: updated exports for the logger #23

Closed Keyrxng closed 4 months ago

Keyrxng commented 4 months ago

image

Keyrxng commented 4 months ago

on it. How do we bump the package version, manually via package json or is there a certain flow to follow? @gentlementlegen

I saw you manually bumped it the commits so I done the same.

gentlementlegen commented 4 months ago

Release please will automatically generate the changelogs based on the conventional commits, bump the version accordingly, and publish the package once all of these changes are merge into the main branch, so no need to do it manually.

Keyrxng commented 4 months ago

Release please will automatically generate the changelogs based on the conventional commits, bump the version accordingly, and publish the package once all of these changes are merge into the main branch, so no need to do it manually.

Right okay, so should I revert the manual bump I just committed or it doesn't matter because release-please will handle it anyway?

gentlementlegen commented 4 months ago

Correct, please revert the bump and the changelog changes.

Keyrxng commented 4 months ago

Correct, please revert the bump and the changelog changes.

So unless I redo the pull and fix the conventional commits the changelog won't change I expect since I used chore: for each commit which seems to be ignored, if everything is automated that is. I will keep this in mind when committing to other npm packages going forward

gentlementlegen commented 4 months ago

@Keyrxng It is also valid to name your PR with a conventional commit name, it should be picked up.

I renamed, and yes moving forward it is always nicer to properly name the commits if they introduce fixes, features etc.

Keyrxng commented 4 months ago

That's a good feature and I know my commit habits are poor (but improving 😂) especially commit names, everything is a chore to me but I will do @gentlementlegen cheers

Keyrxng commented 4 months ago

@gentlementlegen happy to approve and merge this in so I can use it in start-stop please?

gentlementlegen commented 4 months ago

@Keyrxng please fix this comment and good to go.

Keyrxng commented 4 months ago

@Keyrxng please fix this comment and good to go.

The changes here are because of prettier and are purely markdown syntax changes (same output). I can replace - with * and add CHANGELOG.md to .prettierignore?

gentlementlegen commented 4 months ago

@Keyrxng It will be totally re-generated on next release so it doesn't really matter, but why not I guess.