Closed Keyrxng closed 5 months ago
Because this needs to run in a worker env it's likely util
will need replaced with an alternative. Here I just went with JSON.stringify()
, I did try the npm package util
but didn't have much success with it.
@gitcoindev what would your suggestion be here if it does need replaced?
const messageFormatted = typeof message === "string"
? message
: util.inspect(message, { showHidden: true, depth: null, breakLength: Infinity });
@Keyrxng The dist
folder got into the commits, I don't think that's wanted.
@Keyrxng The
dist
folder got into the commits, I don't think that's wanted.
https://github.com/ubiquity/ubiquibot-logger/tree/development/dist
I was keeping things the same as the dev branch but if that is not wanted I shall remove it.
I think this was a mistake to commit it because it contains generated js
and map
which are most likely generating by bundling tools. You also might want to update the .gitignore
because it only ignores static/dist
.
Agreed and I have included it in the .gitignore
in the same commit I removed the dir
@Keyrxng Thank you. Is there any tests associated with the changes in this repo? If not, should definitely nice to have in another PR.
Resolves #2
It makes sense to remove the direct capability to do this from within the logger itself.
formatting and styling remains the same, when the logger calls
_log
it returns aLogReturn
object which the invoker can use to post or store.I have removed the Supabase and GH comment posting ability completely (can be returned if the need for it exists tho it seems more likely only the kernel should be able to post to SB and comment control is on a per-plugin basis and this should be a simple runtime logger and nothing more)