search

ubiquity-os / ubiquity-os-logger

0 stars 6 forks source link

logger unit tests #6

Closed Keyrxng closed 5 months ago

Keyrxng commented 5 months ago

Resolves #5 Requires #4

Keyrxng commented 5 months ago

@gentlementlegen added some tests covering things. I've also decided to remove util and just go with JSON.stringify.

The difference I could see writing these simple tests was not significant enough to remain using it when it may be a problem down the line. Essentially it was including things like array length and such but I don't feel this is awfully useful information when weighing the pros and cons.

Keyrxng commented 5 months ago

@gentlementlegen I've cleaned things up, bumped ts and the plugins being used and removed those that were not and updated the wf

Seems that no dependencies are required according to Knip and from running the tests after everything seems to be working so I've removed those too.

Removed what comments were not needed, the code is pretty straight forward so not many are needed but I've left some