Improvements

[Keyrxng]

Resolves #19

Changes:

• readme display
• production config only
• reset to defaults

QA:

https://github.com/user-attachments/assets/20fb3e2c-994f-46be-8a1c-bb8e27e2678a

[Keyrxng]

This PR became quite long so I will address tests in another task

@rndquu @gentlementlegen if you'd like to take a look when you can, cheers.

[gentlementlegen]

Seems to work fine although I have a few remarks:

• I don't seem to have padding like in your video

  

• the left panel shifts a bit when hovering the "use default" button

• I am only seeing two orgs but I am in more orgs that that, how are they chosen?

• going back from the edit plugin menu makes the bar take the full width

  

• the "remove" button should maybe be disabled on plugins that are not installed

[Keyrxng]

I am only seeing two orgs but I am in more orgs that that, how are they chosen?

https://docs.github.com/en/rest/orgs/orgs?apiVersion=2022-11-28#list-organizations-for-the-authenticated-user

public async getGitHubUserOrgs(): Promise<string[]> {
    const octokit = await this.getOctokit();
    const response = await octokit.rest.orgs.listForAuthenticatedUser();
    return response.data.map((org: { login: string }) => org.login);
  }

What orgs did you see?

I've considered other methods but the question is: What orgs do you want to see?

• Orgs that you are an admin of or just owner of, collaborator of?
• Should the partner determine which roles can edit the config or do we enforce rules, if we enforce then what should they be?

I think a task should be created and it discussed there because it'll involve additional work and direction.

We sort of scrapped global config variables from ubiquity-os-config.yml but we could leverage that to enforce partner defined roles which can edit (at least via the UI).

E.g: The org owner must use it after kernel-setup and we allow them to input roles that can edit and we write this to the config separate from plugins: and we read this on fetch and check against our authenticated user.

[Keyrxng]

the left panel shifts a bit when hovering the "use default" button

I couldn't reproduce this pls lmk if it happens again and what you suggest as a fix/steps to repro, cheers

[zugdev]

We should only show "no orgs available" after we've looked at the request answer, it can be confusing in high latency environments. Show "loading", either as string or animation. Perhaps copy from work.ubq.fi.

[zugdev]

1. Though I've selected an org there is no visual indicator of what org I am at, this can be confusing.

2. README fails to be opened for me. Also, no console.error log to help debug this.

[Keyrxng]

README fails to be opened for me. Also, no console.error log to help debug this.

Any chance you wrote a log to find out as I cannot repro and I don't think it happened for mentlegen either or he'd have mentioned it?

I can add a console.error but would like to know the root cause as me adding a log won't resolve it, appreciate if you could.

We should only show "no orgs available"

I thought this notification was enough but I have updated the title for while it's fetching also

[zugdev]

These icons are not intuitive, perhaps text is better.

[Keyrxng]

These icons are not intuitive, perhaps text is better.

They do have text when hovered and were part of 0x4007's original implementation I just tried to adopt a similar approach for reset to defaults but if you think just text would be better I can do that lmk.

[zugdev]

Some responsiveness issues, not sure if relevant as of this PR:

[zugdev]

json is not vertically expanding for me:

https://github.com/user-attachments/assets/cc0b8c1c-e623-47bf-a8cf-0e0822d7197e

[zugdev]

Once a plugin config is added, a popup appears to push to GitHub. I think we either directly push (kinda dangerous), or offer a "shopping cart" where changes get added to your "cart" and partner reviews it all before pushing.

Also, if I push and go back the plugin won't appear as green/added until I refresh:

https://github.com/user-attachments/assets/3405fd4f-b263-4b24-8e39-8f86d29fccb5

[Keyrxng]

json is not vertically expanding for me:

d.mp4

1. That is relevant to https://github.com/ubiquity-os/ubiquity-os-plugin-installer/issues/14. If you don't have that plugin installed all of those fields render as null and specific handling has not been implemented yet.
2. You'll notice that it does expand on other plugins

Once a plugin config is added, a popup appears to push to GitHub. I think we either directly push (kinda dangerous), or offer a "shopping cart" where changes get added to your "cart" and partner reviews it all before pushing.

If you ignore or close the notification you should be able to continue building other plugins continuously, so there is a shopping cart in effect but hidden. Think it's worth a little legend display what plugins are stored but not yet pushed?

Some responsiveness issues, not sure if relevant as of this PR:

Not sure exactly what you are referring to, I assume the height mismatch?

Some plugins render a < 250px modal, convo-rewards is the largest and is going to become much larger after https://github.com/ubiquity-os/ubiquity-os-plugin-installer/issues/14, so just introduce a basic scroll for the editor and capped it's size to the readme?

[zugdev]

Any chance you wrote a log to find out as I cannot repro and I don't think it happened for mentlegen either or he'd have mentioned it?

Cleared cache and is now working smooth, perhaps it was on my end. If I can repro again I'll debug.

I thought this notification was enough but I have updated the title for while it's fetching also

I think styling decisions are more opinion based comments than direct request for changes. Just let it be for now, unless agreed by team.