search

ubiquity / .github

3 stars 8 forks source link

Reusable workflow #79

Closed whilefoo closed 11 months ago

whilefoo commented 11 months ago

resolves https://github.com/ubiquity/ts-template/issues/6

test pull request using reusable workflow: https://github.com/whilefoo/pay.ubq.fi/pull/7

caller workflow: https://github.com/whilefoo/pay.ubq.fi/blob/development/.github/workflows/continuous-deploy.yml

0x4007 commented 11 months ago

Can you make sure that it appears like our ubiquity-dollar deploys? https://github.com/ubiquity/ubiquity-dollar/pull/723#issuecomment-1625048100

rndquu commented 11 months ago

@whilefoo

The original issue describes the following features:

  1. Add feature of supporting custom domains like 2aa376b3.pay-ubq-fi.ubiquitydao.dev
  2. So in the end we should get a reusable workflow which produces the following deploy result comment by the ubiquibot

Are they implemented?

it should post the commit hashes all in the same comment (I have a feeling this capability was broken) but it used to work https://github.com/ubiquity/ubiquity-dollar/pull/710#issuecomment-1619262232

This was not really part of the current issue and that feature of printing deployment URLs in a single comment seems not to be working correctly so we can add this feature later.

ubiquibot[bot] commented 11 months ago

Available commands

- /assign: Assign the origin sender to the issue automatically.
- /unassign: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /multiplier: Set bounty multiplier (for treasury)
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 
  ex2: /wallet vitalik.eth

@rndquu

whilefoo commented 11 months ago

@rndquu should I reuse the util function for commenting from print-deployments-logs.js?

rndquu commented 11 months ago

@rndquu should I reuse the util function for commenting from print-deployments-logs.js?

yes, you could try to reuse it

ubiquibot[bot] commented 11 months ago

Available commands

- /assign: Assign the origin sender to the issue automatically.
- /unassign: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /multiplier: Set bounty multiplier (for treasury)
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 
  ex2: /wallet vitalik.eth

@rndquu

whilefoo commented 11 months ago

now supports custom domain, auths as a ubiquity bot and correct style: https://github.com/whilefoo/pay.ubq.fi/pull/7

rndquu commented 11 months ago

The linked example looks good so I assume this code is functional! Can we get it to auth as the official UbiquiBot or is there a security issue with that? @rndquu

Can we get it to auth as the official UbiquiBot

Yes, it is just a matter of setting 2 github secrets which we already have set up in the ubiquity org (one and two)

ubiquibot[bot] commented 11 months ago

Available commands

- /assign: Assign the origin sender to the issue automatically.
- /unassign: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /multiplier: Set bounty multiplier (for treasury)
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 
  ex2: /wallet vitalik.eth

@rndquu