`audit` dApp: Show issues with unclaimed permits

rndquu commented 1 year ago

Depends on https://github.com/ubiquity/pay.ubq.fi/issues/100, https://github.com/ubiquity/pay.ubq.fi/issues/110

Right now the audit page only displays issues with claimed permits.

We should also show issues with unclaimed permits.

PhantomCracker commented 1 year ago

Can we set the price so we can assign this? Also, @rndquu we should show all the issues that are closed, right?

ubiquibot[bot] commented 1 year ago

Available commands


- /assign: Assign the origin sender to the issue automatically.
- /unassign: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 
  ex2: /wallet vitalik.eth

@PhantomCracker

PhantomCracker commented 1 year ago

/assign

ubiquibot[bot] commented 1 year ago



  
    
    
  
  
    Deadline
    Thu, 27 Jul 2023 09:38:03 GMT
  
  
    Registered Wallet
    0xCAC0A8cF4cc7073b040c7fe6328Da7f229AF40A6
  
  
    Payment Multiplier
    1.00
  
  
    Multiplier Reason
    
  
  
    Total Bounty
    Permit generation skipped since price label is not set

Tips:

Use /wallet 0x4FDE...BA18 if you want to update your registered payment wallet address @user.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

rndquu commented 1 year ago

Also, @rndquu we should show all the issues that are closed, right?

Yes

ubiquibot[bot] commented 1 year ago

Do you have any updates @PhantomCracker? If you would like to release the bounty back to the DevPool, please comment /unassign Last activity time: Thu Jul 27 2023 08:38:01 GMT+0000 (Coordinated Universal Time)

PhantomCracker commented 1 year ago

Work in progress here, I think today I will finish it

PhantomCracker commented 1 year ago

@rndquu can I have the etherscan API and RPC url?

rndquu commented 1 year ago

@rndquu can I have the etherscan API and RPC url?

Check the code

PhantomCracker commented 1 year ago

@rndquu I am not sure what I do wrong here...

devpanther commented 1 year ago

@rndquu I am not sure what I do wrong here...

You are supposed to be on the /audit path

PhantomCracker commented 1 year ago

You are supposed to be on the /audit path

Can you be more specific please? Maybe you can provide an example of URL?... I just don't get it where this audit page is 😢

devpanther commented 1 year ago

You are supposed to be on the /audit path

Can you be more specific please? Maybe you can provide an example of URL?... I just don't get it where this audit page is 😢

Make it http://localhost:8080/audit.html

ubiquibot[bot] commented 1 year ago

Do you have any updates @PhantomCracker? If you would like to release the bounty back to the DevPool, please comment /unassign Last activity time: Fri Aug 04 2023 07:13:42 GMT+0000 (Coordinated Universal Time)

PhantomCracker commented 1 year ago

I guess that today I will release the PR :) I really hope so

0x4007 commented 1 year ago

You should be working on a draft pull request.

PhantomCracker commented 1 year ago

Ok, I will open it now.

ubiquibot[bot] commented 1 year ago

Do you have any updates @PhantomCracker? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Thu Aug 10 2023 14:18:03 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 1 year ago

@PhantomCracker - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Thu Aug 10 2023 14:18:03 GMT+0000 (Coordinated Universal Time)

PhantomCracker commented 1 year ago

/assign

gentlementlegen commented 8 months ago

This issue depends on https://github.com/ubiquity/pay.ubq.fi/issues/110, since it changes the logic to fetch the permits.

rndquu commented 8 months ago

This issue depends on ubiquity/pay.ubq.fi#110, since it changes the logic to fetch the permits.

Thank you, updated the description

gentlementlegen commented 8 months ago

/start

ubiquibot[bot] commented 8 months ago



Warning!  This task was created over 210 days ago. Please confirm that this issue specification is accurate before starting.
Deadline Thu, Feb 22, 3:07 AM UTC

Registered Wallet
0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED

Tips:

Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

gentlementlegen commented 8 months ago

For unclaimed permits, I am currently displaying UNCLAIMED in the tx column, and I disabled the links for the tx and amount columns, to avoid having links redirecting to 404 pages. Please let me know if you desire a different behavior.

0x4007 commented 8 months ago

For unclaimed permits, I am currently displaying UNCLAIMED in the tx column, and I disabled the links for the tx and amount columns, to avoid having links redirecting to 404 pages. Please let me know if you desire a different behavior.

It should be null in the database, and not say anything in the UI.

gentlementlegen commented 8 months ago

The request to the new repo is ready at https://github.com/ubiquity/audit.ubq.fi/pull/2

0x4007 commented 8 months ago

We need the labels restored before the payment can be made.

@FernandVEYRIER how long did it take we can just use your time input

gentlementlegen commented 8 months ago

@pavlovcik Took < 2 hours, we spent more time reverting changes again and again as we discussed in the original PR here haha https://github.com/ubiquity/pay.ubq.fi/pull/172

molecula451 commented 8 months ago

here is:

image_2024-03-04_233533086

0x4007 commented 8 months ago

Haha we did it at the same time. I'll just add a little cause of the real world feedback of how long it took and usually F is fast

molecula451 commented 8 months ago

Haha we did it at the same time. I'll just add a little cause of the real world feedback of how long it took and usually F is fast

indeed, haha re-do to < 4 hours

ubiquibot[bot] commented 8 months ago

+ Evaluating results. Please wait...

ubiquibot[bot] commented 8 months ago

[ 13.6 WXDAI ]

@pavlovcik

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	4	9.7
Review	Comment	2	3.9

Conversation Incentives

Comment	Formatting	Relevance	Reward
You should be working on a draft pull request. ...	0.9	0.39	0.9
> For unclaimed permits, I am currently displaying `UNCLAIMED` i...	3.4 code: count: 2 score: "2" words: 2	0.28	3.4
We need the labels restored before the payment can be made. @F...	2.4	0.49	2.4
Haha we did it at the same time. I'll just add a little cause of...	3	0.2	3
> Got the error > > ``` > Error: 🧨 Failed: Resource not acc...	2.4 code: count: 2 score: "2" words: 1	0.21	2.4
Merge conflict so can't merge but once that's resolved I think j...	1.5	0.605	1.5

[ 15.35 WXDAI ]

@PhantomCracker

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	7	15.35

Conversation Incentives

Comment	Formatting	Relevance	Reward
Can we set the price so we can assign this? Also, @rndquu we sh...	2.2	0.21	2.2
Work in progress here, I think today I will finish it...	1.1	0.74	1.1
@rndquu can I have the etherscan API and RPC url?...	1	0.59	1
@rndquu I am not sure what I do wrong here... > You are supposed to be on the `/audit` path Can you be more...	5.45 code: count: 1 score: "0.25" words: 1	0.16	5.45
I guess that today I will release the PR :) I really hope so...	1.3	0.34	1.3
Ok, I will open it now....	0.6	0.65	0.6

[ 262.6 WXDAI ]

@FernandVEYRIER

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	200
Issue	Comment	4	0
Issue	Comment	4	12.2
Review	Comment	2	25.2
Review	Comment	2	25.2

Conversation Incentives

Comment	Formatting	Relevance	Reward
This issue depends on https://github.com/ubiquity/pay.ubq.fi/iss...	-	0.55	-
For unclaimed permits, I am currently displaying `UNCLAIMED` in ...	- code: count: 1 score: "0" words: 1	0.44	-
The request to the new repo is ready at https://github.com/ubiqu...	-	0.22	-
@pavlovcik Took < 2 hours, we spent more time reverting changes ...	-	0.37	-
This issue depends on https://github.com/ubiquity/pay.ubq.fi/iss...	2.2	0.55	2.2
For unclaimed permits, I am currently displaying `UNCLAIMED` in ...	5.1 code: count: 1 score: "1" words: 1	0.44	5.1
The request to the new repo is ready at https://github.com/ubiqu...	1.8	0.22	1.8
@pavlovcik Took < 2 hours, we spent more time reverting changes ...	3.1	0.37	3.1
Got the error ``` Error: 🧨 Failed: Resource not accessible by...	16.4 code: count: 2 score: "2" words: 1	0.15	16.4
It seems that there is a `permissions: write-all` in the Action....	8.8 code: count: 2 score: "2" words: 3	0.49	8.8
Got the error ``` Error: 🧨 Failed: Resource not accessible by...	16.4 code: count: 2 score: "2" words: 1	0.15	16.4
It seems that there is a `permissions: write-all` in the Action....	8.8 code: count: 2 score: "2" words: 3	0.49	8.8

[ 0.9 WXDAI ]

@molecula451

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	2	0.9

Conversation Incentives

Comment	Formatting	Relevance	Reward
here is: ![image_2024-03-04_233533086](https://github.com/ubi...	0.2	0.23	0.2
> Haha we did it at the same time. I'll just add a little cause ...	0.7	0.08	0.7

[ 4.6 WXDAI ]

@devpanther

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	2	4.6

Conversation Incentives

Comment	Formatting	Relevance	Reward
> @rndquu I am not sure what I do wrong here... You are supp...	1.9 code: count: 1 score: "1" words: 1	0.12	1.9
> > You are supposed to be on the `/audit` path > > Can you be ...	2.7 code: count: 2 score: "2" words: 6	0.22	2.7

[ 2.5 WXDAI ]

@gitcoindev

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	1	2.5

Conversation Incentives

Comment	Formatting	Relevance	Reward
> Knip CI is failing but I don't think it should block this PR f...	2.5	0.735	2.5

[ 11.6 WXDAI ]

@rndquu

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	8.8
Issue	Comment	3	2.8

Conversation Incentives

Comment	Formatting	Relevance	Reward
Depends on https://github.com/ubiquity/pay.ubq.fi/issues/100, ht...	8.8 a: count: 1 score: "1" words: 2	1	8.8
> Also, @rndquu we should show all the issues that are closed, r...	0.2	0.25	0.2
> @rndquu can I have the etherscan API and RPC url? Check the...	1.6 a: count: 1 score: "1" words: 1	0.41	1.6
> This issue depends on ubiquity/pay.ubq.fi#110, since it change...	1	0.61	1

0x4007 commented 8 months ago

Looks like issue specification multiplier is not being applied. I think none of the multipliers work on the existing comment-incentives because also relevance isnt being applied to the final score. That's too bad. Looking forward to upgrading to the next version!

https://github.com/ubiquity/ubiquibot-config/blob/development/.github/ubiquibot-config.yml#L15


Deadline	Thu, 27 Jul 2023 09:38:03 GMT
Registered Wallet	0xCAC0A8cF4cc7073b040c7fe6328Da7f229AF40A6
Payment Multiplier	1.00
Multiplier Reason
Total Bounty	Permit generation skipped since price label is not set

Warning!	This task was created over 210 days ago. Please confirm that this issue specification is accurate before starting.
Deadline	Thu, Feb 22, 3:07 AM UTC
Registered Wallet	0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED

ubiquity / audit.ubq.fi