ubiquity / business-development

Grant and Proposal documents
1 stars 4 forks source link

W3F Revisions #30

Open 0x4007 opened 1 year ago

0x4007 commented 1 year ago

Thanks for the application @pavlovcik a couple of initial comments/questions:

  • Regarding the milestones, the mandatory deliverables look good (0a. - 0d.) but delivery table descriptions 1 - 6 seem to still be the template > boilerplate text. Can you replace this with the concrete technical deliverables that you would produce?
  • We only fund software that doesn't exist yet, and it seems that some of the DevPool tools have already been > built, such as ubiquibot. Can you specify in the application what you would be building as part of the > grant? The more technical details the better.
  • For any front-end focused milestones, we typically ask for mockups to be presented in the application.
  • Please also note that we typically only fund ink! smart contracts, as we aren't Solidity experts.

Originally posted by @keeganquigley in https://github.com/w3f/Grants-Program/pull/1800#pullrequestreview-1478244982

0x4007 commented 1 year ago

@sergfeldman @Hodlatoor

sergfeldman commented 1 year ago

Thanks for the application @pavlovcik a couple of initial comments/questions:

  • Regarding the milestones, the mandatory deliverables look good (0a. - 0d.) but delivery table descriptions 1 - 6 seem to still be the template > boilerplate text. Can you replace this with the concrete technical deliverables that you would produce?
  • We only fund software that doesn't exist yet, and it seems that some of the DevPool tools have already been > built, such as ubiquibot. Can you specify in the application what you would be building as part of the > grant? The more technical details the better.
  • For any front-end focused milestones, we typically ask for mockups to be presented in the application.
  • Please also note that we typically only fund ink! smart contracts, as we aren't Solidity experts.

Originally posted by @keeganquigley in w3f/Grants-Program#1800 (review)

W3F requests technical deliverables on ther chains, but we do not plan to create and provide them.

0x4007 commented 1 year ago

Is our answer that we will not continue? I feel like there's probably a way to pull this off while still conforming to their requirements.

ubiquibot[bot] commented 1 year ago

@Hodlatoor The time limit for this bounty is on Sat, 17 Jun 2023 07:22:57 GMT

Hodlatoor commented 1 year ago

@sergfeldman Hi Ser, so we have 4 items to address:

  1. Regarding the milestones, the mandatory deliverables look good (0a. - 0d.) but delivery table descriptions 1 - 6 seem to still be the template > boilerplate text. Can you replace this with the concrete technical deliverables that you would produce?

What concrete deliverables do we want to introduce in your mind? I think we should narrow the scope quite a bit.

  1. We only fund software that doesn't exist yet, and it seems that some of the DevPool tools have already been > built, such as ubiquibot. Can you specify in the application what you would be building as part of the > grant? The more technical details the better.

How about we make this granular? To make things clear, let's call it "UbiquiTask" what it does is what we define in #1. This way it's brand new, clear and the functionality which currently doesn't exist, is easily understood.

  1. For any front-end focused milestones, we typically ask for mockups to be presented in the application.

Let's finalize UbiquiTask and can do SC / Wireframes

  1. Please also note that we typically only fund ink! smart contracts, as we aren't Solidity experts.

Doesn't sound like a problem. Ink! projects are on GitHub. We are project agnostic so implicitly we also support Ink! products.

Let's get #1 sorted and the rest falls into place.

0x4007 commented 1 year ago

Whoever is opening the pull request and providing the deliverable should be the assignee. Also I'm not keen on a flippant rebrand across the codebase/github, twitter, telegram and docs on the website just for a grant.

Hodlatoor commented 1 year ago

So to clarify, Think of it as a wheel. DP is the wheel. The wheel has different components like a tire and a rim. In the scope of this grant and for clarity, what we are building now is the rim. We are not rebranding anything.

The wheel is DP. The rim is Ubiquitask. Alongside Ubiquibot (the tire) and other code it makes the wheel.

Just naming a specific set of new components we are building under this grant for the sake of clarity.

sergfeldman commented 1 year ago

@pavlovcik @Hodlatoor If you decide that it is needed, I can try to add this ^ information.


At the moment, I suggest asking W3F in the PR comment like this:

"DevPool is a chain-agnostic solution without technical deliverables on Substrate. At the same time, DevPool accelerates Open Source development and brings value for the development community. The details are in the grant application.

We would like to get your feedback on the solution, and if you see the perspectives, then a grant. Can you evaluate this a bit non-usual grant application?"

Hodlatoor commented 1 year ago

I don't think that's a good idea. I think we give them what they ask for.

sergfeldman commented 1 year ago

@sergfeldman Hi Ser, so we have 4 items to address:

  1. Regarding the milestones, the mandatory deliverables look good (0a. - 0d.) but delivery table descriptions 1 - 6 seem to still be the template > boilerplate text. Can you replace this with the concrete technical deliverables that you would produce?

What concrete deliverables do we want to introduce in your mind? I think we should narrow the scope quite a bit.

  1. We only fund software that doesn't exist yet, and it seems that some of the DevPool tools have already been > built, such as ubiquibot. Can you specify in the application what you would be building as part of the > grant? The more technical details the better.

How about we make this granular? To make things clear, let's call it "UbiquiTask" what it does is what we define in #1. This way it's brand new, clear and the functionality which currently doesn't exist, is easily understood.

  1. For any front-end focused milestones, we typically ask for mockups to be presented in the application.

Let's finalize UbiquiTask and can do SC / Wireframes

  1. Please also note that we typically only fund ink! smart contracts, as we aren't Solidity experts.

Doesn't sound like a problem. Ink! projects are on GitHub. We are project agnostic so implicitly we also support Ink! products.

Let's get #1 sorted and the rest falls into place.

@pavlovcik please clarify, do you approve these 4 activities?

0x4007 commented 1 year ago

@pavlovcik please clarify, do you approve these 4 activities?

I would rather delegate the strategy/decisions to you guys. Besides, the penalty of getting this wrong is basically just opening a new pull request.

  1. Regarding the milestones, the mandatory deliverables look good (0a. - 0d.) but delivery table descriptions 1 - 6 seem to still be the template > boilerplate text. Can you replace this with the concrete technical deliverables that you would produce?

What concrete deliverables do we want to introduce in your mind? I think we should narrow the scope quite a bit.

It is most likely going to be milestones on our development roadmap for the bot.

  1. We only fund software that doesn't exist yet, and it seems that some of the DevPool tools have already been > built, such as ubiquibot. Can you specify in the application what you would be building as part of the > grant? The more technical details the better.

Milestones, again.

  1. For any front-end focused milestones, we typically ask for mockups to be presented in the application.

This is generic advice that isn't applicable to our proposal.

  1. Please also note that we typically only fund ink! smart contracts, as we aren't Solidity experts.

This is also generic advice that isn't applicable to our proposal. However Hodlatoor's comment is worth adding in.

Hodlatoor commented 1 year ago

@sergfeldman let's run some ideas for #1 - keeping it simple and effective.

Hodlatoor commented 1 year ago

@pavlovcik do you want to msg noc2 to reopen saying forthcoming? https://github.com/w3f/Grants-Program/pull/1800#pullrequestreview-1478244982 @sergfeldman let's try and get the deliverables for 1 sorted out so I can modify around it and we can resubmit.

0x4007 commented 1 year ago

No need to bother them with another action until we have something to show. Otherwise we are just wasting their time.

Hodlatoor commented 1 year ago

@pavlovcik @sergfeldman what do you think if we made the new deliverable something like: Building the InkHunterBot which will have 3 core components, for eg:

  1. Creating and deploying the functionality that allows automated confirmation of completed issues by cross-referencing Github code repositories and submissions.
  2. Confirmation of successful deliverable by issuer and payment distribution to hunter.
  3. Integration with UbiquiBot and specific prioritization for Ink! protocols with 10% bounty bonus for Ink! bounties for the first 6 months.
0x4007 commented 1 year ago
  1. That's up to the contributors to associate their changes to a bounty. Bad idea to try and automate when the bounty hunters 100% know what problem they are trying to solve vs the bot trying to guess.
  2. We already do that
  3. This is just a (manual) incentive model for a specific partner, it isn't building a feature.
sergfeldman commented 1 year ago

@pavlovcik @Hodlatoor We discussed that for the W3F application Milestones we will use modules or features that doesn't exist yet and are pending or imminent in the DevPool development.

I've reviewed the DevPool roadmap and all open issues. The modules or features could be related to areas: 1) Financial Incentives. 2) Artificial Intelligence.

Features related to Financial Incentives look highly relevant because they accelerate Open Source development that could be valuable for W3F. I have not yet figured out a definite NEW milestone with clear technical deliverables because implementation of many features is in progress now.

Modules or features related to AI can be relevant as well but I'm not sure we will implement them in the near future.

I will continue defining Milestones tomorrow.

Hodlatoor commented 1 year ago

@sergfeldman financial incentives should be good. as long as we delineate milestones.

sergfeldman commented 1 year ago

@Hodlatoor Please, review the example of the Milestone table.

Number Deliverable Specification
0a. License MIT
0b. Documentation We will provide inline documentation
0c. Testing and Testing Guide Core functions will be fully covered by comprehensive unit tests to ensure functionality and robustness. In the guide, we will describe how to run these tests.
0d. GitHub Issue We will provide GitHub Issues as proof of functionality (this is functional as a deliverable because the bot runs inside of GitHub). We already built the capability for the bot to run automatically off of a GitHub Actions runner bundled within the source code repository, which can be cross-referenced with the GitHub Issues as proof if needed. https://github.com/ubiquity/ubiquibot/issues/311, https://github.com/ubiquity/devpool-directory-bounties/issues/4, https://github.com/ubiquity/devpool-directory/issues/502, https://github.com/ubiquity/ubiquibot/issues/228, https://github.com/ubiquity/ubiquibot/issues/394, https://github.com/ubiquity/ubiquibot/issues/425, https://github.com/ubiquity/ubiquibot/issues/268, https://github.com/ubiquity/ubiquibot/issues/96, https://github.com/ubiquity/ubiquibot/issues/302
0e. Article We will publish an article that explains what was done as part of the grant. Completion of the tasks related to the Open Source Contributor Incentive Suite - a system of financial incentives, notifications, and reports that fairly reward Open Source project contributors.
1. Substrate module: X No Substrate deliverables
2. Substrate module: Y No Substrate deliverables
3. Substrate module: Z No Substrate deliverables
4. Substrate chain No Substrate deliverables
5. Library: ABC No Substrate deliverables
6. Smart contracts: ... No Substrate deliverables
Hodlatoor commented 1 year ago

are you suggesting the work scope will be:

0x4007 commented 1 year ago

fully covered by comprehensive unit tests

Side note but this will be a major project too.

Hodlatoor commented 1 year ago

correct me if I'm missing something but it looks like a list of items that are not very jointed and I can see them having a hard time understanding what it is that they're paying for.
that list doesn't answer a simple question: "with your funds we will build a ____"

Hodlatoor commented 1 year ago

What about a bounty value estimator based on existing bounty data, user data and the betting component? Call it: Bounty Expert AI v1.

0x4007 commented 1 year ago

What about a bounty value estimator based on existing bounty data, user data and the betting component? Call it: Bounty Expert AI v1.

We're already working on crowdsourcing that information with the Thales/Synthetix grant.

Hodlatoor commented 1 year ago

What about a bounty value estimator based on existing bounty data, user data and the betting component? Call it: Bounty Expert AI v1.

We're already working on crowdsourcing that information with the Thales/Synthetix grant.

Yes that's why I mentioned it because we can piggyback off of that And I can see that as a module that is defined and purpose-built.

0x4007 commented 1 year ago

I expect that crowdsourcing this information will solve the business problem with higher accuracy than estimates over the short-to-mid-term. Perhaps on the scale of years will the purely machine estimation engine be more accurate, but it would make sense to seed its intelligence with the crowdsourced human input first. Afterwards, we can source all of the bounty time estimate intelligence from our partners.

Either way, at this stage it doesn't make sense to build.

Hodlatoor commented 1 year ago

So the problem is they are hesitant to fund existing upgrades. I think we should make this into it's own core component which can be utilized in other applications, DevPool included. To that end, let's call it the Aries Crowd Source Engine for DevPool (or any other name you want) and we build it, alongside hooks and elements which help customize it into DevPool.

As such, Aries CrowdSource Engine integration into DevPool is comprised of the following unique components and tools:

Milestone 3 (Crowdsource pricing engine logic)

milestone 2 (Aries related process optimization) : https://github.com/ubiquity/ubiquibot/issues/311 https://github.com/ubiquity/devpool-directory-bounties/issues/4 https://github.com/ubiquity/devpool-directory/issues/502 https://github.com/ubiquity/ubiquibot/issues/268 https://github.com/ubiquity/ubiquibot/issues/302

milestone 1 (Aries related UI/UX enhancements): https://github.com/ubiquity/ubiquibot/issues/228 https://github.com/ubiquity/ubiquibot/issues/394 https://github.com/ubiquity/ubiquibot/issues/425 https://github.com/ubiquity/ubiquibot/issues/96

sergfeldman commented 1 year ago

@Hodlatoor Please, review the example of the Milestone table.

Number Deliverable Specification 0a. License MIT 0b. Documentation We will provide inline documentation 0c. Testing and Testing Guide Core functions will be fully covered by comprehensive unit tests to ensure functionality and robustness. In the guide, we will describe how to run these tests. 0d. GitHub Issue We will provide GitHub Issues as proof of functionality (this is functional as a deliverable because the bot runs inside of GitHub). We already built the capability for the bot to run automatically off of a GitHub Actions runner bundled within the source code repository, which can be cross-referenced with the GitHub Issues as proof if needed. ubiquity/ubiquibot#311, ubiquity/devpool-directory-bounties#4, ubiquity/devpool-directory#502, ubiquity/ubiquibot#228, ubiquity/ubiquibot#394, ubiquity/ubiquibot#425, ubiquity/ubiquibot#268, ubiquity/ubiquibot#96, ubiquity/ubiquibot#302 0e. Article We will publish an article that explains what was done as part of the grant. Completion of the tasks related to the Open Source Contributor Incentive Suite - a system of financial incentives, notifications, and reports that fairly reward Open Source project contributors.

  1. Substrate module: X No Substrate deliverables
  2. Substrate module: Y No Substrate deliverables
  3. Substrate module: Z No Substrate deliverables
  4. Substrate chain No Substrate deliverables
  5. Library: ABC No Substrate deliverables
  6. Smart contracts: ... No Substrate deliverables

@Hodlatoor The main area for review - questions 1-6 are still without answers. Other content is secondary.

As it is hard to find a new DevPool module that meets all the requirements, I artificially compiled "Open Source Contributor Incentives Suite - a system of financial incentives, notifications, and reports that fairly reward Open Source project contributors" with these ^ currently open issues as examples.

If you prefer an artificially compiled "Aries Crowd Source Engine for DevPool which can be utilized in other applications, DevPool included", it is totally fine for me.

Hodlatoor commented 1 year ago

@pavlovcik @sergfeldman Guys - take a look. https://www.notion.so/ubiquitydao/Aries-Crowd-Source-Engine-extensible-and-deployed-on-DevPool-ef867161bf314e9785315160c9311f70?pvs=4

0x4007 commented 1 year ago

We aren't using notion anymore you should be doing this in GitHub in a markdown document added to the repo, and request us as reviewers.

https://dao.ubq.fi/non-code-devpool-deliverables-process

Hodlatoor commented 1 year ago

https://github.com/Hodlatoor/partnerships/blob/2496c4f926c81ceff6b1e05ed1c89c724b5b82a6/Aries%20CS%20Engine

tried to go back and edit to associate the task but couldn't see where. was worried more about the formatting.

also how do I move it into the /github folder and add chores / associate task now that it's there?

sergfeldman commented 1 year ago

https://github.com/Hodlatoor/partnerships/blob/2496c4f926c81ceff6b1e05ed1c89c724b5b82a6/Aries%20CS%20Engine

tried to go back and edit to associate the task but couldn't see where. was worried more about the formatting.

also how do I move it into the /github folder and add chores / associate task now that it's there?

@Hodlatoor I created the PR with 3 Milestone tables required for the W3F grant. The content in these Milestone tables is based on yours https://github.com/Hodlatoor/partnerships/pull/1

@pavlovcik Please, let me know if I created the PR not correctly.

0x4007 commented 1 year ago

https://github.com/Hodlatoor/partnerships/blob/2496c4f926c81ceff6b1e05ed1c89c724b5b82a6/Aries%20CS%20Engine

tried to go back and edit to associate the task but couldn't see where. was worried more about the formatting.

also how do I move it into the /github folder and add chores / associate task now that it's there?

That's a good start.

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

Hodlatoor commented 1 year ago

@sergfeldman are we all good and submitted here so we can close this task?

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

0x4007 commented 1 year ago

Can you try opening up a pull request and associating this issue with your deliverable?

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

0x4007 commented 1 year ago

lol @0xcodercrane can you tame this bot

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign

ubiquibot[bot] commented 1 year ago

Do you have any updates @Hodlatoor? If you would like to release the bounty back to the DevPool, please comment /unassign