Open rndquu opened 6 months ago
Prob should be high priority if it's CI for all repos
Prob should be high priority if it's CI for all repos
I'll fix it as part of https://github.com/ubiquity/cloudflare-deploy-action/issues/1, this issue more of a reminder
@rndquu is this issue finished in #1 ?
@rndquu is this issue finished in #1 ?
No, you're free to take it
@rndquu is this issue finished in #1 ?
No, you're free to take it
understood,how should i test the same?
We can start with getting DEPLOYMENT_URL from the bash script for deploying to cloudflare https://github.com/ubiquity/cloudflare-deploy-action/blob/5454d2d0d1a8efc44ff894825605b03f109f8986/.github/cloudflare-deploy.sh#L39
Set an output up for downstream actions
echo "::set-output name=deploy_url::${{ env.DEPLOYMENT_URL }}"
Then could get that back as an output from something like here =>
url: ${{steps.deploy.outputs.deploy_url}}
please confirm this logic and i'll make the PR asap
We can start with getting DEPLOYMENT_URL from the bash script for deploying to cloudflare
Set an output up for downstream actions
echo "::set-output name=deploy_url::${{ env.DEPLOYMENT_URL }}"
Then could get that back as an output from something like here =>
url: ${{steps.deploy.outputs.deploy_url}}
please confirm this logic and i'll make the PR asap
Sounds good
@rndquu is this issue finished in #1 ?
No, you're free to take it
understood,how should i test the same?
Not sure what you mean by "test the same"
@rndquu is this issue finished in #1 ?
No, you're free to take it
understood,how should i test the same?
Not sure what you mean by "test the same"
I meant to ask,how would we test this workflow in action?
@rndquu is this issue finished in #1 ?
No, you're free to take it
understood,how should i test the same?
Not sure what you mean by "test the same"
I meant to ask,how would we test this workflow in action?
Test locally first (i.e. in one of your workflows)
/start
Warning! | This task was created over 120 days ago. Please confirm that this issue specification is accurate before starting. |
Deadline | Fri, Jul 12, 3:37 PM UTC |
Registered Wallet | 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025 |
/wallet 0x0000...0000
if you want to update your registered payment wallet address.
Original comment
We should pass cloudflare deployment preview to cypress workflow here.
What should be done:
FRONTEND_URL
env variable to https://github.com/ubiquity/cloudflare-deploy-action output