ubiquity / cloudflare-deploy-action

A reusable, and automatic Cloudflare deploy for instant previews across @ubiquity repositories.
0 stars 9 forks source link

Output deployment URL #4

Open rndquu opened 6 months ago

rndquu commented 6 months ago

Original comment

We should pass cloudflare deployment preview to cypress workflow here.

What should be done:

  1. Update current github action to return deployment URL in output (example)
  2. Update all ubiquity repos which use cypress workflow and set FRONTEND_URL env variable to https://github.com/ubiquity/cloudflare-deploy-action output
0x4007 commented 6 months ago

Prob should be high priority if it's CI for all repos

rndquu commented 6 months ago

Prob should be high priority if it's CI for all repos

I'll fix it as part of https://github.com/ubiquity/cloudflare-deploy-action/issues/1, this issue more of a reminder

0xJoichiro commented 4 months ago

@rndquu is this issue finished in #1 ?

rndquu commented 4 months ago

@rndquu is this issue finished in #1 ?

No, you're free to take it

0xJoichiro commented 4 months ago

@rndquu is this issue finished in #1 ?

No, you're free to take it

understood,how should i test the same?

0xJoichiro commented 4 months ago

We can start with getting DEPLOYMENT_URL from the bash script for deploying to cloudflare https://github.com/ubiquity/cloudflare-deploy-action/blob/5454d2d0d1a8efc44ff894825605b03f109f8986/.github/cloudflare-deploy.sh#L39

Set an output up for downstream actions

        echo "::set-output name=deploy_url::${{ env.DEPLOYMENT_URL }}"

Then could get that back as an output from something like here =>

       url: ${{steps.deploy.outputs.deploy_url}}

please confirm this logic and i'll make the PR asap

rndquu commented 4 months ago

We can start with getting DEPLOYMENT_URL from the bash script for deploying to cloudflare

https://github.com/ubiquity/cloudflare-deploy-action/blob/5454d2d0d1a8efc44ff894825605b03f109f8986/.github/cloudflare-deploy.sh#L39

Set an output up for downstream actions

        echo "::set-output name=deploy_url::${{ env.DEPLOYMENT_URL }}"

Then could get that back as an output from something like here =>

       url: ${{steps.deploy.outputs.deploy_url}}

please confirm this logic and i'll make the PR asap

Sounds good

rndquu commented 4 months ago

@rndquu is this issue finished in #1 ?

No, you're free to take it

understood,how should i test the same?

Not sure what you mean by "test the same"

0xJoichiro commented 4 months ago

@rndquu is this issue finished in #1 ?

No, you're free to take it

understood,how should i test the same?

Not sure what you mean by "test the same"

I meant to ask,how would we test this workflow in action?

rndquu commented 4 months ago

@rndquu is this issue finished in #1 ?

No, you're free to take it

understood,how should i test the same?

Not sure what you mean by "test the same"

I meant to ask,how would we test this workflow in action?

Test locally first (i.e. in one of your workflows)

Sadaf-A commented 2 months ago

/start

ubiquibot[bot] commented 2 months ago

Warning! This task was created over 120 days ago. Please confirm that this issue specification is accurate before starting.
DeadlineFri, Jul 12, 3:37 PM UTC
Registered Wallet 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025
Tips: