More Robust Server Error Handling

[0x4007]

I was checking the entire flow of how new people perceive our site, and our developer onboarding flow through dao.ubq.fi/devpool etc as I do regularly these days (to ensure seamless onboarding!) and realized that work.ubq.fi only rendered nine tasks.

I was quick to assume I got rate limited but realized that there indeed are only nine tasks open in the devpool-directory "backend"

Fortunately GitHub Actions has logs and I was able to discover

Getting ubiquity org repositories failed: HttpError: Server Error

This is a problem because it actually closes all the issues when this occurs!

The script should be smart enough to ignore the @ubiquity org tasks in this situation in case there are 5xx level errors!

[ubiquibot[bot]]

! action has an uncaught error

[ubiquibot[bot]]

! action has an uncaught error

[ubiquibot[bot]]

! action has an uncaught error

[ubiquibot[bot]]

! action has an uncaught error

[ubiquibot[bot]]

! action has an uncaught error

[EresDev]

/start

[EresDev]

/start

[ubiquibot[bot]]

! action has an uncaught error

[EresDev]

/wallet 0xE7a9fdf596D869AF34a130fa9607178B2B9800D9

[ubiquibot[bot]]

! action has an uncaught error

[EresDev]

/start

[0x4007]

@FernandVEYRIER any ideas?

[ubiquibot[bot]]

@EresDev the deadline is at 2024-03-18T08:08:34.068Z

[gentlementlegen]

@FernandVEYRIER any ideas?

Not really if the bot is using the service role key. Do you have more details on the logs?

[0x4007]

All logs should be visible in supabase public.logs table!

[gentlementlegen]

{
  "name": "HttpError",
  "caller": "getAllCommitsFromPullRequest",
  "status": 404,
  "request": {
    "url": "https://api.github.com/repos/ubiquity/devpool-directory-bounties/pulls/1145/commits?per_page=100",
    "method": "GET",
    "headers": {
      "accept": "application/vnd.github.v3+json",
      "user-agent": "probot/12.3.3 octokit-core.js/3.6.0 Node.js/20.11.0 (linux; x64)",
      "authorization": "token [REDACTED]"
    },
    "request": {
      "retryCount": 1
    }
  },
  "response": {
    "url": "https://api.github.com/repos/ubiquity/devpool-directory-bounties/pulls/1145/commits?per_page=100",
    "data": {
      "message": "Not Found",
      "documentation_url": "https://docs.github.com/rest/pulls/pulls#list-commits-on-a-pull-request"
    },
    "status": 404,
    "headers": {
      "date": "Mon, 18 Mar 2024 06:13:29 GMT",
      "vary": "Accept-Encoding, Accept, X-Requested-With",
      "server": "GitHub.com",
      "content-type": "application/json; charset=utf-8",
      "referrer-policy": "origin-when-cross-origin, strict-origin-when-cross-origin",
      "x-frame-options": "deny",
      "content-encoding": "gzip",
      "x-ratelimit-used": "149",
      "x-xss-protection": "0",
      "transfer-encoding": "chunked",
      "x-ratelimit-limit": "7200",
      "x-ratelimit-reset": "1710742875",
      "x-github-media-type": "github.v3; format=json",
      "x-github-request-id": "D088:3BDA:2304A49:4162F3C:65F7DB88",
      "x-ratelimit-resource": "core",
      "x-ratelimit-remaining": "7051",
      "x-content-type-options": "nosniff",
      "content-security-policy": "default-src 'none'",
      "strict-transport-security": "max-age=31536000; includeSubdomains; preload",
      "access-control-allow-origin": "*",
      "access-control-expose-headers": "ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset",
      "x-accepted-github-permissions": "pull_requests=read",
      "x-github-api-version-selected": "2022-11-28"
    }
  },
  "revision": null
}

Seems related to the changes made to fetch the data related to a pull request through the locations table contained in the database, not the CLS.

[gitcoindev]

Hi, is it just me noticing because I just got up or simply the pull request URL is wrong? 404 error is correct, because it does not exist. The correct URL is likely https://api.github.com/repos/ubiquity/devpool-directory/pulls/1145

[gentlementlegen]

@gitcoindev Yes the url seems to be wrong. It seems to be using the current repo to create that URL since here we are inside devpool-directory-bounties/issues/21

[0x4007]

It's searching to see 1. if you aren't assigned to too many other issues simultaneously (we have default limits for 2 concurrent task assignments, so that contributors can stay focused) and 2. to see if you have any recent activity in the form of comments or commits on any of the tasks you are assigned to, in order to see if you were idle for a week and unassign you.

[EresDev]

I was quick to assume I got rate limited but realized that there indeed are only nine tasks open in the devpool-directory "backend"

Fortunately GitHub Actions has logs and I was able to discover

Github API Rate limit error codes are 4xx, timeout error codes are 5xx. This appears to be timeout error.

From the Github API docs

If GitHub takes more than 10 seconds to process an API request, GitHub will terminate the request and you will receive a timeout response and a "Server Error" message.

The script should be smart enough to ignore the @ubiquity org tasks in this situation in case there are 5xx level errors!

This solution looks ok but a better solution is to improve error handling of the function. The above failure occurred when the bot couldn't even fetch a list of repos for the org. This list was important. The function should have ended (waiting for it to restart at next hour), instead of doing the rest of the work and end up closing wrong issues.

I am planning to do this. If a timeout or rate limit error occur, stop the execution of the function. Print more details related to rate limit, response code, and wait for the function to restart at next hour.

[ubiquibot[bot]]

! action has an uncaught error

[ubiquibot[bot]]

+ Evaluating results. Please wait...

[ubiquibot[bot]]

[ 42 WXDAI ]

@pavlovcik

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	24
Issue	Comment	3	18

Conversation Incentives

Comment	Formatting	Relevance	Reward
I was checking the entire flow of how new people perceive our si...	24 a: count: 1 score: "1" words: 8	1	24
@FernandVEYRIER any ideas?...	0.6	0.69	0.6
All logs should be visible in supabase `public.logs` table!...	3 code: count: 1 score: "1" words: 2	0.79	3
It's searching to see 1. if you aren't assigned to too many othe...	14.4	0.835	14.4

[ 37.5 WXDAI ]

@FernandVEYRIER

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	3	37.5

Conversation Incentives

Comment	Formatting	Relevance	Reward
> @FernandVEYRIER any ideas? Not really if the bot is using t...	1.9	0.55	1.9
```JSON { "name": "HttpError", "caller": "getAllCommitsFr...	31.6 code: count: 2 score: "2" words: 1	0.77	31.6
@gitcoindev Yes the url seems to be wrong. It seems to be using ...	4 code: count: 1 score: "1" words: 5	0.78	4

[ 5.3 WXDAI ]

@gitcoindev

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	5.3

Conversation Incentives

Comment	Formatting	Relevance	Reward
Hi, is it just me noticing because I just got up or simply the p...	5.3 a: count: 1 score: "1" words: 10	0.84	5.3

[EresDev]

/wallet 0xE7a9fdf596D869AF34a130fa9607178B2B9800D9

[ubiquibot[bot]]

! action has an uncaught error

[ubiquibot[bot]]

+ Evaluating results. Please wait...

[ubiquibot[bot]]

[ 42 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	24
Issue	Comment	3	18

Conversation Incentives

Comment	Formatting	Relevance	Reward
I was checking the entire flow of how new people perceive our si...	24 a: count: 1 score: "1" words: 8	1	24
@FernandVEYRIER any ideas?...	0.6	0.62	0.6
All logs should be visible in supabase `public.logs` table!...	3 code: count: 1 score: "1" words: 2	0.71	3
It's searching to see 1. if you aren't assigned to too many othe...	14.4	0.82	14.4

[ 37.5 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	3	37.5

Conversation Incentives

Comment	Formatting	Relevance	Reward
> @FernandVEYRIER any ideas? Not really if the bot is using t...	1.9	0.61	1.9
```JSON { "name": "HttpError", "caller": "getAllCommitsFr...	31.6 code: count: 2 score: "2" words: 1	0.78	31.6
@gitcoindev Yes the url seems to be wrong. It seems to be using ...	4 code: count: 1 score: "1" words: 5	0.84	4

[ 212.8 WXDAI ]

@EresDev

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	200
Issue	Comment	1	0
Issue	Comment	1	12.8

Conversation Incentives

Comment	Formatting	Relevance	Reward
> I was quick to assume I got rate limited but realized that the...	-	0.82	-
> I was quick to assume I got rate limited but realized that the...	12.8	0.82	12.8

[ 5.3 WXDAI ]

@gitcoindev

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	5.3

Conversation Incentives

Comment	Formatting	Relevance	Reward
Hi, is it just me noticing because I just got up or simply the p...	5.3 a: count: 1 score: "1" words: 10	0.61	5.3